Skip to content

Commit 18d57d2

Browse files
committed
Updated comments on pull-up resistors
1 parent 34a8185 commit 18d57d2

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

Diff for: libraries/SD_MMC/examples/SDMMC_Test/SDMMC_Test.ino

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
* | █/
2323
* |__▍___▊___█___█___█___█___█___█___/
2424
* WARNING: ALL data pins must be pulled up to 3.3V with an external 10k Ohm resistor!
25-
* Note to ESP32 pin 2 (D0): Add a 1K Ohm pull-up resistor after flashing
25+
* Note to ESP32 pin 2 (D0): Add a 1K Ohm pull-up resistor to 3.3V after flashing
2626
*
2727
* For more info see file README.md in this library or on URL:
2828
* https://github.com/espressif/arduino-esp32/tree/master/libraries/SD_MMC
@@ -38,7 +38,7 @@
3838
// Note: ESP32-S3-WROOM-1 does not have GPIO 33 and 34 broken out.
3939
// Note: The board ESP32-S3-USB-OTG has predefined default pins and the following definitions with the setPins() call will not be compiled.
4040
// Note: Pins in this definition block are ordered from top down in order in which they are on the full-sized SD card
41-
// from left to right when facing the pins down (when connected to a breadboard)
41+
// from left to right when facing the pins down (when connected to a breadboard)
4242

4343
#if defined(SOC_SDMMC_USE_GPIO_MATRIX) && not defined(BOARD_HAS_SDMMC)
4444
int d1 = 21; // SD pin 8 - Add a 10k Ohm pull-up resistor to 3.3V if using 4-bit mode (use_1_bit_mode = false)
@@ -237,7 +237,7 @@ void setup(){
237237
if(!SD_MMC.begin("/sdcard", use_1_bit_mode)){
238238
Serial.println("Card Mount Failed.");
239239
Serial.println("Increase log level to see more info: Tools > Core Debug Level > Verbose");
240-
Serial.println("Make sure that all data pins have a 10k Ohm pull-up resistor");
240+
Serial.println("Make sure that all data pins have a 10k Ohm pull-up resistor to 3.3V");
241241
#ifdef SOC_SDMMC_USE_GPIO_MATRIX
242242
Serial.println("Make sure that when using generic ESP32-S3 board the pins are setup using SD_MMC.setPins()");
243243
#endif

Diff for: libraries/SD_MMC/examples/SDMMC_time/SDMMC_time.ino

+9-9
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
* | █/
2323
* |__▍___▊___█___█___█___█___█___█___/
2424
* WARNING: ALL data pins must be pulled up to 3.3V with external 10k Ohm resistor!
25-
* Note to ESP32 pin 2 (D0): Add 1K Ohm pull-up resistor after flashing
25+
* Note to ESP32 pin 2 (D0): Add 1K Ohm pull-up resistor to 3.3V after flashing
2626
*
2727
* For more info see file README.md in this library or on URL:
2828
* https://github.com/espressif/arduino-esp32/tree/master/libraries/SD_MMC
@@ -47,18 +47,18 @@ byte daysavetime = 1;
4747
// Note: ESP32-S3-WROOM-1 does not have GPIO 33 and 34 broken out.
4848
// Note: The board ESP32-S3-USB-OTG has predefined default pins and the following definitions with the setPins() call will not be compiled.
4949
// Note: Pins in this definition block are ordered from top down in order in which they are on the full-sized SD card
50-
// from left to right when facing the pins down (when connected to a breadboard)
50+
// from left to right when facing the pins down (when connected to a breadboard)
5151

5252
#if defined(SOC_SDMMC_USE_GPIO_MATRIX) && not defined(BOARD_HAS_SDMMC)
53-
int d1 = 21; // SD pin 8 - Add 10k Ohm pull-up if using 4-bit mode (use_1_bit_mode = false)
54-
int d0 = 47; // SD pin 7 - Add 10k Ohm pull-up
53+
int d1 = 21; // SD pin 8 - Add a 10k Ohm pull-up resistor to 3.3V if using 4-bit mode (use_1_bit_mode = false)
54+
int d0 = 47; // SD pin 7 - Add a 10k Ohm pull-up resistor to 3.3V
5555
// GND pin - SD pin 6
56-
int clk = 39; // SD pin 5 - Add 10k Ohm pull-up
56+
int clk = 39; // SD pin 5 - Add a 10k Ohm pull-up resistor to 3.3V
5757
// 3.3V pin - SD pin 4
5858
// GND pin - SD pin 3
59-
int cmd = 40; // SD pin 2 - Add 10k Ohm pull-up
60-
int d3 = 41; // SD pin 1 - Add 10k Ohm pull-up to card's pin even when using 1-bit mode
61-
int d2 = 42; // SD pin 9 - Add 10k Ohm pull-up if using 4-bit mode (use_1_bit_mode = false)
59+
int cmd = 40; // SD pin 2 - Add a 10k Ohm pull-up resistor to 3.3V
60+
int d3 = 41; // SD pin 1 - Add a 10k Ohm pull-up resistor to 3.3V to card's pin even when using 1-bit mode
61+
int d2 = 42; // SD pin 9 - Add a 10k Ohm pull-up resistor to 3.3V if using 4-bit mode (use_1_bit_mode = false)
6262
#endif
6363

6464
bool use_1_bit_mode = false; // Change the value to `true` to use 1-bit mode instead of the 4-bit mode
@@ -240,7 +240,7 @@ void setup(){
240240
if(!SD_MMC.begin("/sdcard", use_1_bit_mode)){
241241
Serial.println("Card Mount Failed.");
242242
Serial.println("Increase log level to see more info: Tools > Core Debug Level > Verbose");
243-
Serial.println("Make sure that all data pins have a 10k Ohm pull-up resistor");
243+
Serial.println("Make sure that all data pins have a 10k Ohm pull-up resistor to 3.3V");
244244
#ifdef SOC_SDMMC_USE_GPIO_MATRIX
245245
Serial.println("Make sure that when using generic ESP32-S3 board the pins are setup using SD_MMC.setPins()");
246246
#endif

0 commit comments

Comments
 (0)