fix

Author: lucasssvaz

.github/scripts/on-push.sh

@@ -10,40 +10,38 @@ function build {
     local chunks_cnt=$3
     local build_log=$4
     local sketches_file=$5
-    shift; shift; shift; shift; shift;
-    local sketches=$*
+    shift 5
+    local sketches=("$@")
 
     local BUILD_SKETCH="${SCRIPTS_DIR}/sketch_utils.sh build"
     local BUILD_SKETCHES="${SCRIPTS_DIR}/sketch_utils.sh chunk_build"
 
-    local args="-ai $ARDUINO_IDE_PATH -au $ARDUINO_USR_PATH"
-
-    args+=" -t $target"
+    local args=("-ai" "$ARDUINO_IDE_PATH" "-au" "$ARDUINO_USR_PATH" "-t" "$target")
 
     if [ "$OS_IS_LINUX" == "1" ]; then
-        args+=" -p $ARDUINO_ESP32_PATH/libraries"
-        args+=" -i $chunk_index -m $chunks_cnt"
+        args+=("-p" "$ARDUINO_ESP32_PATH/libraries" "-i" "$chunk_index" "-m" "$chunks_cnt")
         if [ -n "$sketches_file" ]; then
-            args+=" -f $sketches_file"
+            args+=("-f" "$sketches_file")
         fi
         if [ "$build_log" -eq 1 ]; then
-            args+=" -l $build_log"
+            args+=("-l" "$build_log")
         fi
-        ${BUILD_SKETCHES} "${args}"
+        "${BUILD_SKETCHES}" "${args[@]}"
     else
-        for sketch in ${sketches}; do
-            local sargs
+        for sketch in "${sketches[@]}"; do
+            local sargs=("${args[@]}")
             local ctags_version
             local preprocessor_version
-            sargs="$args -s $(dirname "$sketch")"
+            sargs+=("-s" "$(dirname "$sketch")")
             if [ "$OS_IS_WINDOWS" == "1" ] && [ -d "$ARDUINO_IDE_PATH/tools-builder" ]; then
                 ctags_version=$(ls "$ARDUINO_IDE_PATH/tools-builder/ctags/")
                 preprocessor_version=$(ls "$ARDUINO_IDE_PATH/tools-builder/arduino-preprocessor/")
-                win_opts="-prefs=runtime.tools.ctags.path=$ARDUINO_IDE_PATH/tools-builder/ctags/$ctags_version
-                -prefs=runtime.tools.arduino-preprocessor.path=$ARDUINO_IDE_PATH/tools-builder/arduino-preprocessor/$preprocessor_version"
-                sargs+=" ${win_opts}"
+                sargs+=(
+                    "-prefs=runtime.tools.ctags.path=$ARDUINO_IDE_PATH/tools-builder/ctags/$ctags_version"
+                    "-prefs=runtime.tools.arduino-preprocessor.path=$ARDUINO_IDE_PATH/tools-builder/arduino-preprocessor/$preprocessor_version"
+                )
             fi
-            ${BUILD_SKETCH} "${sargs}"
+            "${BUILD_SKETCH}" "${sargs[@]}"
         done
     fi
 }

.github/scripts/sketch_utils.sh

@@ -398,7 +398,6 @@ function count_sketches { # count_sketches <path> [target] [file] [ignore-requir
 }
 
 function build_sketches { # build_sketches <ide_path> <user_path> <target> <path> <chunk> <total-chunks> [extra-options]
-
     local args=""
     while [ -n "$1" ]; do
         echo "arg: $1"