Fixing issue in String::remove

me-no-dev · me-no-dev · commit 0e55f775d3bd · 2021-03-04T22:41:46.000+02:00
diff --git a/cores/esp32/WString.cpp b/cores/esp32/WString.cpp
@@ -796,8 +796,8 @@ void String::remove(unsigned int index, unsigned int count) {
     }
     char *writeTo = wbuffer() + index;
     unsigned int newlen = len() - count;
-    setLen(newlen);
     memmove(writeTo, wbuffer() + index + count, newlen - index);
+    setLen(newlen);
     wbuffer()[newlen] = 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -796,8 +796,8 @@ void String::remove(unsigned int index, unsigned int count) {`
`796`	`796`	`}`
`797`	`797`	`char *writeTo = wbuffer() + index;`
`798`	`798`	`unsigned int newlen = len() - count;`
`799`		`- setLen(newlen);`
`800`	`799`	`memmove(writeTo, wbuffer() + index + count, newlen - index);`
	`800`	`+ setLen(newlen);`
`801`	`801`	`wbuffer()[newlen] = 0;`
`802`	`802`	`}`
`803`	`803`