Skip to content

Commit 0acbe78

Browse files
authored
Increase default timeout for WiFiClient from 3ms to 3s (#5496)
## Summary #5487 introduced a default timeout for WiFiClient, however the default was specified in milliseconds instead of seconds, see be84c82#commitcomment-54358731 This 3ms timeout breaks OTA when the processor is busy. ## Impact Sets the default to a saner value, fixes OTA.
1 parent 0b0dfab commit 0acbe78

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

Diff for: libraries/WiFi/src/WiFiClient.cpp

+10-10
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@
2323
#include <lwip/netdb.h>
2424
#include <errno.h>
2525

26-
#define WIFI_CLIENT_DEF_CONN_TIMEOUT (3)
27-
#define WIFI_CLIENT_MAX_WRITE_RETRY (10)
28-
#define WIFI_CLIENT_SELECT_TIMEOUT_US (1000000)
29-
#define WIFI_CLIENT_FLUSH_BUFFER_SIZE (1024)
26+
#define WIFI_CLIENT_DEF_CONN_TIMEOUT_MS (3000)
27+
#define WIFI_CLIENT_MAX_WRITE_RETRY (10)
28+
#define WIFI_CLIENT_SELECT_TIMEOUT_US (1000000)
29+
#define WIFI_CLIENT_FLUSH_BUFFER_SIZE (1024)
3030

3131
#undef connect
3232
#undef write
@@ -208,9 +208,9 @@ void WiFiClient::stop()
208208

209209
int WiFiClient::connect(IPAddress ip, uint16_t port)
210210
{
211-
return connect(ip,port,WIFI_CLIENT_DEF_CONN_TIMEOUT);
212-
}
213-
int WiFiClient::connect(IPAddress ip, uint16_t port, int32_t timeout)
211+
return connect(ip,port,WIFI_CLIENT_DEF_CONN_TIMEOUT_MS);
212+
}
213+
int WiFiClient::connect(IPAddress ip, uint16_t port, int32_t timeout )
214214
{
215215
int sockfd = socket(AF_INET, SOCK_STREAM, 0);
216216
if (sockfd < 0) {
@@ -279,9 +279,9 @@ int WiFiClient::connect(IPAddress ip, uint16_t port, int32_t timeout)
279279

280280
int WiFiClient::connect(const char *host, uint16_t port)
281281
{
282-
return connect(host,port,WIFI_CLIENT_DEF_CONN_TIMEOUT);
283-
}
284-
int WiFiClient::connect(const char *host, uint16_t port, int32_t timeout)
282+
return connect(host,port,WIFI_CLIENT_DEF_CONN_TIMEOUT_MS);
283+
}
284+
int WiFiClient::connect(const char *host, uint16_t port, int32_t timeout )
285285
{
286286
IPAddress srv((uint32_t)0);
287287
if(!WiFiGenericClass::hostByName(host, srv)){

0 commit comments

Comments
 (0)