Skip to content

Commit 055be33

Browse files
authored
fix(ppp): uncomment error logging, change new function naming
1 parent 81f98e5 commit 055be33

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

libraries/PPP/src/PPP.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,7 @@ int PPPClass::RSSI() const {
499499
int rssi, ber;
500500
esp_err_t err = esp_modem_get_signal_quality(_dce, rssi, ber);
501501
if (err != ESP_OK) {
502-
// log_e("esp_modem_get_signal_quality failed with %d %s", err, esp_err_to_name(err));
502+
log_e("esp_modem_get_signal_quality failed with %d %s", err, esp_err_to_name(err));
503503
return -1;
504504
}
505505
return rssi;
@@ -511,7 +511,7 @@ int PPPClass::BER() const {
511511
int rssi, ber;
512512
esp_err_t err = esp_modem_get_signal_quality(_dce, rssi, ber);
513513
if (err != ESP_OK) {
514-
// log_e("esp_modem_get_signal_quality failed with %d %s", err, esp_err_to_name(err));
514+
log_e("esp_modem_get_signal_quality failed with %d %s", err, esp_err_to_name(err));
515515
return -1;
516516
}
517517
return ber;
@@ -647,37 +647,37 @@ bool PPPClass::setBaudrate(int baudrate) {
647647
return true;
648648
}
649649

650-
int PPPClass::getBatteryVoltage() const {
650+
int PPPClass::batteryVoltage() const {
651651
PPP_CMD_MODE_CHECK(-1);
652652

653653
int volt, bcs, bcl;
654654
esp_err_t err = esp_modem_get_battery_status(_dce, volt, bcs, bcl);
655655
if (err != ESP_OK) {
656-
//log_e("esp_modem_get_battery_status failed with %d %s", err, esp_err_to_name(err));
656+
log_e("esp_modem_get_battery_status failed with %d %s", err, esp_err_to_name(err));
657657
return -1;
658658
}
659659
return volt;
660660
}
661661

662-
int PPPClass::getBatteryLevel() const {
662+
int PPPClass::batteryLevel() const {
663663
PPP_CMD_MODE_CHECK(-1);
664664

665665
int volt, bcs, bcl;
666666
esp_err_t err = esp_modem_get_battery_status(_dce, volt, bcs, bcl);
667667
if (err != ESP_OK) {
668-
//log_e("esp_modem_get_battery_status failed with %d %s", err, esp_err_to_name(err));
668+
log_e("esp_modem_get_battery_status failed with %d %s", err, esp_err_to_name(err));
669669
return -1;
670670
}
671671
return bcl;
672672
}
673673

674-
int PPPClass::getBatteryStatus() const {
674+
int PPPClass::batteryStatus() const {
675675
PPP_CMD_MODE_CHECK(-1);
676676

677677
int volt, bcs, bcl;
678678
esp_err_t err = esp_modem_get_battery_status(_dce, volt, bcs, bcl);
679679
if (err != ESP_OK) {
680-
//log_e("esp_modem_get_battery_status failed with %d %s", err, esp_err_to_name(err));
680+
log_e("esp_modem_get_battery_status failed with %d %s", err, esp_err_to_name(err));
681681
return -1;
682682
}
683683
return bcs;

0 commit comments

Comments
 (0)