Skip to content

ESP now encrypted communications #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mischmerz opened this issue Jul 6, 2018 · 3 comments
Open

ESP now encrypted communications #141

mischmerz opened this issue Jul 6, 2018 · 3 comments

Comments

@mischmerz
Copy link

Weird phenomenon (ESP now) :

I am setting the kok for both units, and am using the keys for add_peer() as well as set_peer_key(). Roles are set properly. Problem is, it kinda works too well :D

a) Controller (no crypto configured) -> Slave (no crypto configured) : OK
b) Controller (valid crypto key) -> Slave (valid crypto key) : OK
c) Controller (invalid crypto key) -> Slave (valid crypto key) :FAIL
d) Controller(valid crypto key) -> Slave (no crypto configured) : FAIL

.. so far .. so good. BUT:

e) Controller (no crypto key configured) -> Slave (valid crypto key) :OK

Seems the controller accepts un-encrypted messages even if a kok has been configured and a crypto key has been set for the peer. This is obviously bad as it doesn't allow the slave to authenticate the controller. It seems to be impossible to determine if the controller used a valid key or no key at all.

Any ideas?

Michaela

@ramiws
Copy link

ramiws commented Dec 6, 2020

Is this will be ever fixed? is there work around ?

@jmzjmzjmz
Copy link

this seems like a pretty big security risk, no? what's stopping someone from flooding an esp now network on the broadcast address?

@ChuckMash
Copy link

Noticed this today.

An ESP8266 without encryption can successfully send ESP-NOW to an ESP8266 with encryption.
This does not appear to impact the ESP32 implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants