From 484c5098fb839b4b4ce16df886e36f32e31b153c Mon Sep 17 00:00:00 2001 From: david gauchard Date: Mon, 5 Apr 2021 14:42:21 +0200 Subject: [PATCH 1/2] ClientContext::connect: add missing `const` --- libraries/ESP8266WiFi/src/include/ClientContext.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/ESP8266WiFi/src/include/ClientContext.h b/libraries/ESP8266WiFi/src/include/ClientContext.h index 43ce731de0..e0a0d160bc 100644 --- a/libraries/ESP8266WiFi/src/include/ClientContext.h +++ b/libraries/ESP8266WiFi/src/include/ClientContext.h @@ -129,7 +129,7 @@ class ClientContext } } - int connect(ip_addr_t* addr, uint16_t port) + int connect(const ip_addr_t* addr, uint16_t port) { #if LWIP_IPV6 // Set zone so that link local addresses use the default interface From c9b3efb19d65e4ef7d822c85ab581b7859cb4dd1 Mon Sep 17 00:00:00 2001 From: david gauchard Date: Mon, 5 Apr 2021 14:52:26 +0200 Subject: [PATCH 2/2] remove `const`, add comment --- libraries/ESP8266WiFi/src/include/ClientContext.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libraries/ESP8266WiFi/src/include/ClientContext.h b/libraries/ESP8266WiFi/src/include/ClientContext.h index e0a0d160bc..d52ef7b4c2 100644 --- a/libraries/ESP8266WiFi/src/include/ClientContext.h +++ b/libraries/ESP8266WiFi/src/include/ClientContext.h @@ -129,8 +129,11 @@ class ClientContext } } - int connect(const ip_addr_t* addr, uint16_t port) + int connect(ip_addr_t* addr, uint16_t port) { + // note: not using `const ip_addr_t* addr` because + // - `ip6_addr_assign_zone()` below modifies `*addr` + // - caller's parameter `WiFiClient::connect` is a local copy #if LWIP_IPV6 // Set zone so that link local addresses use the default interface if (IP_IS_V6(addr) && ip6_addr_lacks_zone(ip_2_ip6(addr), IP6_UNKNOWN)) {