WString explicit converters to reduce Flash size #6759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasmota uses a lot of
String
with constructs like below:Currently for any non
String
argument, the compiler silently instantiates a newString
object and deletes it after the call. This generates more than 1k of not very useful code.This PR adds explicit methods to deal with common arguments
const unsigned char *
andconst __FlashStringHelper *
. It does not change the fact that aString
object is created then deleted, it just reduces redundant code.With this change, we see a 1k code size reduction with Tasmota.