From ae1448cd052749676d8b02117d790a2fb9bab6b5 Mon Sep 17 00:00:00 2001 From: A C SREEDHAR REDDY Date: Thu, 5 Jul 2018 19:55:33 +0530 Subject: [PATCH 1/3] issue #4893 --- libraries/ESP8266mDNS/ESP8266mDNS.cpp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libraries/ESP8266mDNS/ESP8266mDNS.cpp b/libraries/ESP8266mDNS/ESP8266mDNS.cpp index 2344b0833c..851693a29f 100644 --- a/libraries/ESP8266mDNS/ESP8266mDNS.cpp +++ b/libraries/ESP8266mDNS/ESP8266mDNS.cpp @@ -289,7 +289,15 @@ int MDNSResponder::queryService(char *service, char *proto) { #ifdef DEBUG_ESP_MDNS_TX DEBUG_ESP_PORT.printf("queryService %s %s\n", service, proto); #endif - + MDNSAnswer *answer; + int numAnswers = _getNumAnswers(); + for (int n = numAnswers - 1; n >= 0; n--) { + answer = _getAnswerFromIdx(n); + os_free(answer->hostname); + os_free(answer); + answer = 0; + } + _answers = 0; if (_query != 0) { os_free(_query); _query = 0; From da0d55f8b10477d45075bc3e3dd736c8b5746beb Mon Sep 17 00:00:00 2001 From: A C SREEDHAR REDDY Date: Fri, 6 Jul 2018 07:22:55 +0530 Subject: [PATCH 2/3] issue #4893 cleared the linkedlist. --- libraries/ESP8266mDNS/ESP8266mDNS.cpp | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libraries/ESP8266mDNS/ESP8266mDNS.cpp b/libraries/ESP8266mDNS/ESP8266mDNS.cpp index 851693a29f..fc37ac1e64 100644 --- a/libraries/ESP8266mDNS/ESP8266mDNS.cpp +++ b/libraries/ESP8266mDNS/ESP8266mDNS.cpp @@ -289,13 +289,12 @@ int MDNSResponder::queryService(char *service, char *proto) { #ifdef DEBUG_ESP_MDNS_TX DEBUG_ESP_PORT.printf("queryService %s %s\n", service, proto); #endif - MDNSAnswer *answer; - int numAnswers = _getNumAnswers(); - for (int n = numAnswers - 1; n >= 0; n--) { - answer = _getAnswerFromIdx(n); - os_free(answer->hostname); - os_free(answer); - answer = 0; + while(_answers!=0){ + MDNSAnswer *currAnswer = _answers; + _answers = _answers->next; + os_free(currAnswer->hostname); + os_free(currAnswer); + currAnswer = 0; } _answers = 0; if (_query != 0) { From 010c95246152d12f435e241261f0fa9e9a82217d Mon Sep 17 00:00:00 2001 From: A C SREEDHAR REDDY Date: Fri, 6 Jul 2018 07:25:50 +0530 Subject: [PATCH 3/3] issue #4893 --- libraries/ESP8266mDNS/ESP8266mDNS.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/libraries/ESP8266mDNS/ESP8266mDNS.cpp b/libraries/ESP8266mDNS/ESP8266mDNS.cpp index fc37ac1e64..c754a2b8cf 100644 --- a/libraries/ESP8266mDNS/ESP8266mDNS.cpp +++ b/libraries/ESP8266mDNS/ESP8266mDNS.cpp @@ -296,7 +296,6 @@ int MDNSResponder::queryService(char *service, char *proto) { os_free(currAnswer); currAnswer = 0; } - _answers = 0; if (_query != 0) { os_free(_query); _query = 0;