-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Binary signing should be available under Windows #5694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This would be predicated on #5635. If we don't include Python by default w/the Windows install, this isn't (sanely) possible. |
@earlephilhower if Python will be installed on Windows (manual step is done one by the user) then this is doable? |
@Misiu, the problem is if python is not installed the IDE will abort when you try and start the signing.py script and it won't ever successfully build a BIN. The referenced PR installs a complete copy of python as part of the core subdirectory, so we can safely call that tool on all Windows boxes and signing.py can then gracefully exit if OpenSSL isn't present. |
Signing should now work if OpenSSL command line utilities are installed since #5635 was merged. |
* Edited OTA readme, added Stream Interface snippet Reworded for easier understanding. Changes mostly in first half of page. * OTA docs: corrected typos, misc edits near end * Incorporated suggestions from earlephilhower Extra ^, removed TODO
I have both Python and openSSL installed and added to the path but I get this error: |
This PR adds support for signing binary file with certificate.
Unfortunately it is available only on Linux and Mac.
As suggested by @earlephilhower I'm oppening this issue to track support for Windows.
OpenSSL it is easily installable on Windows - https://wiki.openssl.org/index.php/Binaries.
I don't mind manual installation of it, especially is it done only once.
If installing OpenSSL manually and adding it to the path (so that OpenSSL executable is available from the command line) is the only step then this should be definitively added to docs.
The text was updated successfully, but these errors were encountered: