Skip to content

IPADDRESS breaking change, empty eval changed #5677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tablatronix opened this issue Jan 27, 2019 · 0 comments · Fixed by #5684
Closed

IPADDRESS breaking change, empty eval changed #5677

tablatronix opened this issue Jan 27, 2019 · 0 comments · Fixed by #5684
Assignees
@d-a-v
Labels
component: network type: bug
Milestone
2.5.0

Comments

@tablatronix
Copy link
Contributor

tablatronix commented Jan 27, 2019 •
edited
Loading 

    IPAddress     thisisanipaddress;
    if(thisisanipaddress){Serial.println("YARP);}  // WAS NARP until ipv6 pr maybe..

Any code checking an unset or NULL ip address will no longer evaluate to false.

various changes to ipaddress.cpp, I am assuming from dword 0, to struct via IP_ANY_TYPE (&ip_addr_any_type) at cursory glance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-a-v d-a-v

Labels
component: network type: bug
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

fix testing IPAddress validity d-a-v/Arduino
2 participants
@tablatronix @d-a-v