-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Support for user provided MD5 credentials for ESP8266WebServer authentication #4392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What threat are you trying to protect against? Sending MD5 over an unsecured channel is still completely insecure as anyone along the path can just replay the MD5 back to authenticate. It's just trading one plaintext password for another. And with rainbow tables, reversing MD5 to get back to plaintext is not a problem for anyone with a computer built this decade. For security, basic HTTP user:pass over an encrypted channel is a common recommendation. There is now a WebServerSecure which can pretty much replace the unencrypted one w/a 1-line addition to supply its certificate and key. |
Agree. Don't know if |
WebServerSecure's in a pretty good state as far as we know. I and @d-a-v have done lots of stress testing on the underlying WiFiServerSecure/ClientSecure. Give it a try, but be aware you need 20KB+ free heap to run a SSL connection. I'd argue MD5 is perfectly easy to decrypt today. See https://hashkiller.co.uk/md5-decrypter.aspx for an online version.... |
It would be great to have an option to provide
ESP8266WebServer
authentication's credentials asMD5
values instead of clear texts.This is useful in case, where
<user:pass>
is stored inMD5
format and is modifiable.Adding an option switch like this, defaulted to
false
, maybe is sufficient:bool authenticate(const char * username, const char * password, bool user_md5 = false);
The text was updated successfully, but these errors were encountered: