Skip to content

ESP8266HTTPUpdateServer fails to check sketch size versus available space #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
igrr opened this issue Jul 4, 2016 · 2 comments · Fixed by #2405
Closed

ESP8266HTTPUpdateServer fails to check sketch size versus available space #2226

igrr opened this issue Jul 4, 2016 · 2 comments · Fixed by #2405
Labels
component: libraries type: bug
Milestone
2.4.0

Comments

@igrr
Copy link
Member

igrr commented Jul 4, 2016

Currently it is possible to upload a sketch which is larger than the space available in flash, i.e. upload 280k sketch into a module with 512k64 flash configuration.
@igrr igrr added this to the 2.4.0 milestone Jul 4, 2016
@me-no-dev
Copy link
Collaborator

how? I checked the code and it calls Update.begin with max available space for OTA
https://github.com/esp8266/Arduino/blob/master/libraries/ESP8266HTTPUpdateServer/src/ESP8266HTTPUpdateServer.cpp#L64

@me-no-dev
Copy link
Collaborator

to maybe better explain, if the uploaded file is larger than the available space, Update should stop writing and flag an error. If that is not the behaviour you are seeing let me know. Maybe the problem is in the Updater class

@me-no-dev me-no-dev mentioned this issue Aug 17, 2016
Merged
@igrr igrr reopened this May 9, 2017
@igrr igrr closed this as completed Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: libraries type: bug
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

make updater fail if there is not enough space to fit the new firmware me-no-dev/Arduino
2 participants
@igrr @me-no-dev