ESP8266WiFiMulti.cpp code inspection: Unexecutable code in ESP8266WiFiMulti::run

[SteveToulouse]

While looking through the code to understand what's being done and see how issue #2117 could be resolved, lines 51 to 63 caught my eye.

The conditions of the "if"s at lines L51 if (scanResult > 0) and L61 if (scanResult <= 0) are mutually exclusive. So the code at line 62 can never be executed. Unless I've missed something?

Not a bug as such (it doesn't break anything) but it adds complexity when reading the code. The enormous "else" clause, from 63 onwards to nearly the end of ::run, could be reduced one indentation level.

EDIT This was introduced by the commit 9a1ff7f

[devyte]

Code reference is still present in latest git. Most likely this
if (scanResult <= 0)
should be
if (scanResult == 0)

[devyte]

@SteveToulouse please take a look at the referenced PR.

[devyte]

I merged the PR after some sanity checks. Any new problems will be handled in a different issue.
Closing.