Skip to content

Callback for WiFi event is not std::function + WiFi.removeEvent has bug #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sticilface opened this issue May 14, 2016 · 1 comment
Closed

Comments

@sticilface
Copy link
Contributor

sticilface commented May 14, 2016

@igrr as, discussed.

https://github.com/esp8266/Arduino/blob/master/libraries/ESP8266WiFi/src/ESP8266WiFiGeneric.h#L38
is not an std::function.

These features are not documented.

https://github.com/esp8266/Arduino/blob/master/libraries/ESP8266WiFi/src/ESP8266WiFiGeneric.cpp#L87

Needs to be refactored, as there is no == operator for std::function, and as you mentioned better to have RAII implementation. (I did try, and you've mentioned there is an error).

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@igrr
Copy link
Member

igrr commented Jun 8, 2016

Created #2119 which addresses this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants