Skip to content

Commit f4a62c0

Browse files
committed
Clean up early out case.
1 parent d1d17d2 commit f4a62c0

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

cores/esp8266/uart.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,15 +106,13 @@ inline size_t uart_rx_fifo_available(uart_t* uart) {
106106
inline void uart_rx_copy_fifo_to_buffer(uart_t* uart) {
107107
while(uart_rx_fifo_available(uart)){
108108
size_t nextPos = (uart->rx_buffer->wpos + 1) % uart->rx_buffer->size;
109-
if(nextPos != uart->rx_buffer->rpos) {
110-
uint8_t data = USF(uart->uart_nr);
111-
uart->rx_buffer->buffer[uart->rx_buffer->wpos] = data;
112-
uart->rx_buffer->wpos = nextPos;
113-
}
114-
else {
109+
if(nextPos == uart->rx_buffer->rpos) {
115110
// Stop copying if rx buffer is full
116111
break;
117112
}
113+
uint8_t data = USF(uart->uart_nr);
114+
uart->rx_buffer->buffer[uart->rx_buffer->wpos] = data;
115+
uart->rx_buffer->wpos = nextPos;
118116
}
119117
}
120118

0 commit comments

Comments
 (0)