Skip to content

Commit cdd2fed

Browse files
committed
Minor code style changes
1 parent c209af0 commit cdd2fed

File tree

4 files changed

+18
-14
lines changed

4 files changed

+18
-14
lines changed

hardware/esp8266com/esp8266/cores/esp8266/Esp.cpp

+7-7
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ void EspClass::restart(void)
7474
system_restart();
7575
}
7676

77-
uint16_t EspClass::getVCC(void)
77+
uint16_t EspClass::getVcc(void)
7878
{
7979
return system_get_vdd33();
8080
}
@@ -89,7 +89,7 @@ uint32_t EspClass::getChipId(void)
8989
return system_get_chip_id();
9090
}
9191

92-
const char * EspClass::getSDKversion(void)
92+
const char * EspClass::getSdkVersion(void)
9393
{
9494
return system_get_sdk_version();
9595
}
@@ -104,7 +104,7 @@ uint8_t EspClass::getBootMode(void)
104104
return system_get_boot_mode();
105105
}
106106

107-
uint8_t EspClass::getCPUfreqMHz(void)
107+
uint8_t EspClass::getCpuFreqMHz(void)
108108
{
109109
return system_get_cpu_freq();
110110
}
@@ -121,7 +121,7 @@ uint32_t EspClass::getFlashChipSize(void)
121121
uint8_t * bytes = (uint8_t *) &data;
122122
// read first 4 byte (magic byte + flash config)
123123
if(spi_flash_read(0x0000, &data, 4) == SPI_FLASH_RESULT_OK) {
124-
switch((bytes[3] & 0xF0) >> 4) {
124+
switch((bytes[3] & 0xf0) >> 4) {
125125
case 0x0: // 4 Mbit (512KB)
126126
return (512 * kB);
127127
case 0x1: // 2 MBit (256KB)
@@ -152,7 +152,7 @@ uint32_t EspClass::getFlashChipSpeed(void)
152152
return (26 * MHz);
153153
case 0x2: // 20 MHz
154154
return (20 * MHz);
155-
case 0xF: // 80 MHz
155+
case 0xf: // 80 MHz
156156
return (80 * MHz);
157157
default: // fail?
158158
return 0;
@@ -163,14 +163,14 @@ uint32_t EspClass::getFlashChipSpeed(void)
163163

164164
FlashMode_t EspClass::getFlashChipMode(void)
165165
{
166-
FlashMode_t mode = FM_FAILD;
166+
FlashMode_t mode = FM_UNKNOWN;
167167
uint32_t data;
168168
uint8_t * bytes = (uint8_t *) &data;
169169
// read first 4 byte (magic byte + flash config)
170170
if(spi_flash_read(0x0000, &data, 4) == SPI_FLASH_RESULT_OK) {
171171
mode = (FlashMode_t) bytes[2];
172172
if(mode > FM_DOUT) {
173-
mode = FM_FAILD;
173+
mode = FM_UNKNOWN;
174174
}
175175
}
176176
return mode;

hardware/esp8266com/esp8266/cores/esp8266/Esp.h

+6-6
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ typedef enum {
5454
FM_QOUT = 0x01,
5555
FM_DIO = 0x02,
5656
FM_DOUT = 0x03,
57-
FM_FAILD = 0xFF
57+
FM_UNKNOWN = 0xff
5858
} FlashMode_t;
5959

6060
class EspClass {
@@ -63,28 +63,28 @@ class EspClass {
6363

6464
// TODO: figure out how to set WDT timeout
6565
void wdtEnable(uint32_t timeout_ms = 0);
66+
// note: setting the timeout value is not implemented at the moment
6667
void wdtEnable(WDTO_t timeout_ms = WDTO_0MS);
6768

6869
void wdtDisable(void);
6970
void wdtFeed(void);
7071

7172
void deepSleep(uint32_t time_us, WakeMode mode = WAKE_RF_DEFAULT);
7273

73-
7474
void reset(void);
7575
void restart(void);
76-
uint16_t getVCC(void);
76+
77+
uint16_t getVcc(void);
7778
uint32_t getFreeHeap(void);
7879

7980
uint32_t getChipId(void);
8081

81-
82-
const char * getSDKversion(void);
82+
const char * getSdkVersion(void);
8383

8484
uint8_t getBootVersion(void);
8585
uint8_t getBootMode(void);
8686

87-
uint8_t getCPUfreqMHz(void);
87+
uint8_t getCpuFreqMHz(void);
8888

8989
uint32_t getFlashChipId(void);
9090
uint32_t getFlashChipSize(void);

hardware/esp8266com/esp8266/libraries/ESP8266WiFi/src/ESP8266WiFi.h

+4
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,10 @@ class ESP8266WiFiClass
223223
*/
224224
bool smartConfigDone();
225225

226+
/*
227+
* Stop SmartConfig
228+
*
229+
*/
226230
void stopSmartConfig();
227231

228232
friend class WiFiClient;

hardware/tools/esp8266/sdk/ld/eagle.app.v6.ld

+1-1
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ SECTIONS
153153
_irom0_text_start = ABSOLUTE(.);
154154
*core_esp8266_*.o(.literal*, .text*)
155155
*.cpp.o(.literal*, .text*)
156-
*libm.a:(.literal .text .literal.* .text.*)
156+
*libm.a:(.literal .text .literal.* .text.*)
157157
*libsmartconfig.a:(.literal .text .literal.* .text.*)
158158
*(.irom0.literal .irom.literal .irom.text.literal .irom0.text .irom.text)
159159
_irom0_text_end = ABSOLUTE(.);

0 commit comments

Comments
 (0)