Skip to content

Commit b250381

Browse files
authored
make updater fail if there is not enough space to fit the new firmware (#2405)
1 parent 4ececda commit b250381

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

cores/esp8266/Updater.cpp

+8-3
Original file line numberDiff line numberDiff line change
@@ -226,12 +226,17 @@ bool UpdaterClass::_writeBuffer(){
226226
}
227227

228228
size_t UpdaterClass::write(uint8_t *data, size_t len) {
229-
size_t left = len;
230229
if(hasError() || !isRunning())
231230
return 0;
232231

233-
if(len > remaining())
234-
len = remaining();
232+
if(len > remaining()){
233+
//len = remaining();
234+
//fail instead
235+
_error = UPDATE_ERROR_SPACE;
236+
return 0;
237+
}
238+
239+
size_t left = len;
235240

236241
while((_bufferLen + left) > FLASH_SECTOR_SIZE) {
237242
size_t toBuff = FLASH_SECTOR_SIZE - _bufferLen;

0 commit comments

Comments
 (0)