Skip to content

Commit 650c8c7

Browse files
Fix esptool windows python path
Fixes a typo in the python path for Windows for upload.
1 parent a2211bf commit 650c8c7

File tree

2 files changed

+15
-10
lines changed

2 files changed

+15
-10
lines changed

package/build_boards_manager_package.sh

+5-1
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,13 @@ fi
7474
# handles tool paths differently when package is installed in hardware folder
7575
cat $srcdir/platform.txt | \
7676
$SED 's/runtime.tools.xtensa-lx106-elf-gcc.path={runtime.platform.path}\/tools\/xtensa-lx106-elf//g' | \
77-
$SED 's/runtime.tools.python.windows.path=.*//g' | \
77+
$SED 's/runtime.tools.python.path=.*//g' | \
7878
$SED 's/runtime.tools.esptool.path={runtime.platform.path}\/tools\/esptool//g' | \
7979
$SED 's/tools.esptool.path={runtime.platform.path}\/tools\/esptool/tools.esptool.path=\{runtime.tools.esptool.path\}/g' | \
80+
$SED 's/^tools.esptool.cmd=.*//g' | \
81+
$SED 's/^tools.esptool.network_cmd=.*//g' | \
82+
$SED 's/^#tools.esptool.cmd=/tools.esptool.cmd=/g' | \
83+
$SED 's/^#tools.esptool.network_cmd=/tools.esptool.network_cmd=/g' | \
8084
$SED 's/tools.mkspiffs.path={runtime.platform.path}\/tools\/mkspiffs/tools.mkspiffs.path=\{runtime.tools.mkspiffs.path\}/g' |\
8185
$SED 's/recipe.hooks.core.prebuild.2.pattern.*//g' |\
8286
$SED "s/version=.*/version=$ver/g" |\

platform.txt

+10-9
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,15 @@
88
name=ESP8266 Boards (2.6.0-dev)
99
version=2.6.0-dev
1010

11+
# These will be removed by the packager script when doing a JSON release
1112
runtime.tools.xtensa-lx106-elf-gcc.path={runtime.platform.path}/tools/xtensa-lx106-elf
13+
runtime.tools.python.path={runtime.platform.path}/tools/python
14+
1215
runtime.tools.esptool.path={runtime.platform.path}/tools/esptool
1316
runtime.tools.signing={runtime.platform.path}/tools/signing.py
1417
runtime.tools.elf2bin={runtime.platform.path}/tools/elf2bin.py
1518
runtime.tools.makecorever={runtime.platform.path}/tools/makecorever.py
1619
runtime.tools.eboot={runtime.platform.path}/bootloaders/eboot/eboot.elf
17-
runtime.tools.python.path=/usr/bin
18-
runtime.tools.python.windows.path={runtime.platform.path}/tools/python
1920

2021
compiler.warning_flags=-w
2122
compiler.warning_flags.none=-w
@@ -66,9 +67,6 @@ compiler.elf2hex.flags=
6667

6768
compiler.size.cmd=xtensa-lx106-elf-size
6869

69-
compiler.esptool.cmd=esptool
70-
compiler.esptool.cmd.windows=esptool.exe
71-
7270
# This can be overriden in boards.txt
7371
build.extra_flags=-DESP8266
7472

@@ -124,11 +122,14 @@ recipe.size.regex.data=^(?:\.data|\.rodata|\.bss)\s+([0-9]+).*
124122
# ------------------------------
125123

126124
# Need to duplicate the python path because Arduino does not replace properly in this stage
127-
tools.esptool.cmd=python
128-
tools.esptool.cmd.windows={runtime.tools.python.windows.path}/python.exe
129125
tools.esptool.path=
130-
tools.esptool.network_cmd=python
131-
tools.esptool.network_cmd.windows={runtime.tools.python.windows.path}/python.exe
126+
# Because the variable expansion doesn't allow one tool to find another, the following lines
127+
# will point to "{runtime.platform.path}/python/python" in GIT and "{runtime.tools.python.path}/python"
128+
# for JSON board manager releases.
129+
#tools.esptool.cmd={runtime.tools.python.path}/python
130+
#tools.esptool.network_cmd={runtime.tools.python.path}/python
131+
tools.esptool.cmd={runtime.platform.path}/python/python
132+
tools.esptool.network_cmd={runtime.platform.path}/python/python
132133

133134
tools.esptool.upload.protocol=esp
134135
tools.esptool.upload.params.verbose=--trace

0 commit comments

Comments
 (0)