Skip to content

Commit 5ba2dd3

Browse files
Make most variables ints, not uint8_ts
Where it doesn't make a functional difference, make global variables ints and not unit8_t. Bytewide updates and extracts require multiple instructions and hence increase IRAM usage as well as runtime.
1 parent 7126fbf commit 5ba2dd3

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

cores/esp8266/core_esp8266_si2c.cpp

+10-10
Original file line numberDiff line numberDiff line change
@@ -59,31 +59,31 @@ static unsigned char twi_addr = 0;
5959
#define TWIP_WRITE 14
6060
#define TWIP_BUS_ERR 15
6161

62-
static volatile uint8_t twip_mode = TWIPM_IDLE;
63-
static volatile uint8_t twip_state = TWIP_IDLE;
64-
static volatile uint8_t twip_status = TW_NO_INFO;
65-
static volatile uint8_t bitCount = 0;
62+
static volatile int twip_mode = TWIPM_IDLE;
63+
static volatile int twip_state = TWIP_IDLE;
64+
static volatile int twip_status = TW_NO_INFO;
65+
static volatile int bitCount = 0;
6666

6767
#define TWDR twi_data
6868
static volatile uint8_t twi_data = 0x00;
69-
static volatile uint8_t twi_ack = 0;
70-
static volatile uint8_t twi_ack_rec = 0;
69+
static volatile int twi_ack = 0;
70+
static volatile int twi_ack_rec = 0;
7171
static volatile int twi_timeout_ms = 10;
7272

7373
#define TWI_READY 0
7474
#define TWI_MRX 1
7575
#define TWI_MTX 2
7676
#define TWI_SRX 3
7777
#define TWI_STX 4
78-
static volatile uint8_t twi_state = TWI_READY;
78+
static volatile int twi_state = TWI_READY;
7979
static volatile uint8_t twi_error = 0xFF;
8080

8181
static uint8_t twi_txBuffer[TWI_BUFFER_LENGTH];
82-
static volatile uint8_t twi_txBufferIndex;
83-
static volatile uint8_t twi_txBufferLength;
82+
static volatile int twi_txBufferIndex;
83+
static volatile int twi_txBufferLength;
8484

8585
static uint8_t twi_rxBuffer[TWI_BUFFER_LENGTH];
86-
static volatile uint8_t twi_rxBufferIndex;
86+
static volatile int twi_rxBufferIndex;
8787

8888
static void (*twi_onSlaveTransmit)(void);
8989
static void (*twi_onSlaveReceive)(uint8_t*, size_t);

0 commit comments

Comments
 (0)