Early firing the ISR causes interruption to other waveforms, let it pick up new starts at next regular interval.

dok-net · dok-net · commit 50ded373f982 · 2022-12-23T10:26:59.000+01:00
diff --git a/cores/esp8266/core_esp8266_waveform_phase.cpp b/cores/esp8266/core_esp8266_waveform_phase.cpp
@@ -195,10 +195,7 @@ int startWaveformClockCycles_weak(uint8_t pin, uint32_t highCcys, uint32_t lowCc
     if (!waveform.timer1Running) {
       initTimer();
     }
-    else if (T1V > IRQLATENCYCCYS) {
-      // Must not interfere if Timer is due shortly
-      timer1_write(IRQLATENCYCCYS);
-    }
+    // The ISR pulls updates on next PWM interval
   }
   else {
     wave.mode = WaveformMode::INFINITE; // turn off possible expiry to make update atomic from NMI

Original file line number	Diff line number	Diff line change
`@@ -195,10 +195,7 @@ int startWaveformClockCycles_weak(uint8_t pin, uint32_t highCcys, uint32_t lowCc`
`195`	`195`	`if (!waveform.timer1Running) {`
`196`	`196`	`initTimer();`
`197`	`197`	`}`
`198`		`- else if (T1V > IRQLATENCYCCYS) {`
`199`		`- // Must not interfere if Timer is due shortly`
`200`		`- timer1_write(IRQLATENCYCCYS);`
`201`		`- }`
	`198`	`+ // The ISR pulls updates on next PWM interval`
`202`	`199`	`}`
`203`	`200`	`else {`
`204`	`201`	`wave.mode = WaveformMode::INFINITE; // turn off possible expiry to make update atomic from NMI`