Skip ':' inside SHA1 signatures in WiFiClientSecure.cpp .

asez73 · asez73 · commit 4be40bc5fa84 · 2015-12-15T11:41:29.000+01:00
Improves the convenience of the verification of fingerprints.
As ':' are commonly inserted by web browser inside the SHA1 of https web sites, this created false problems with signatures "not matching".
Now, copied and pasted signature from Firefox simply because the verify function will skipped them...
diff --git a/libraries/ESP8266WiFi/src/WiFiClientSecure.cpp b/libraries/ESP8266WiFi/src/WiFiClientSecure.cpp
@@ -327,7 +327,7 @@ bool WiFiClientSecure::verify(const char* fp, const char* url) {
     int len = strlen(fp);
     int pos = 0;
     for (size_t i = 0; i < sizeof(sha1); ++i) {
-        while (pos < len && fp[pos] == ' ') {
+        while (pos < len && ((fp[pos] == ' ') || (fp[pos] == ':'))) {
             ++pos;
         }
         if (pos > len - 2) {

Original file line number	Diff line number	Diff line change
`@@ -327,7 +327,7 @@ bool WiFiClientSecure::verify(const char* fp, const char* url) {`
`327`	`327`	`int len = strlen(fp);`
`328`	`328`	`int pos = 0;`
`329`	`329`	`for (size_t i = 0; i < sizeof(sha1); ++i) {`
`330`		`- while (pos < len && fp[pos] == ' ') {`
	`330`	`+ while (pos < len && ((fp[pos] == ' ') \|\| (fp[pos] == ':'))) {`
`331`	`331`	`++pos;`
`332`	`332`	`}`
`333`	`333`	`if (pos > len - 2) {`