Change protocol detection so uppercase or lowercase works (#8137)

idolpx · web-flow · commit 1a5ef712986f · 2021-06-17T15:48:30.000-07:00
Make protocol detection case insensitive
diff --git a/libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.cpp b/libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.cpp
@@ -90,6 +90,7 @@ bool HTTPClient::begin(WiFiClient &client, const String& url) {
     }
 
     String protocol = url.substring(0, index);
+    protocol.toLowerCase();
     if(protocol != "http" && protocol != "https") {
         DEBUG_HTTPCLIENT("[HTTP-Client][begin] unknown protocol '%s'\n", protocol.c_str());
         return false;
@@ -137,6 +138,7 @@ bool HTTPClient::beginInternal(const String& __url, const char* expectedProtocol
     }
 
     _protocol = url.substring(0, index);
+    _protocol.toLowerCase();
     url.remove(0, (index + 3)); // remove http:// or https://
 
     if (_protocol == "http") {

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@ bool HTTPClient::begin(WiFiClient &client, const String& url) {`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`String protocol = url.substring(0, index);`
	`93`	`+ protocol.toLowerCase();`
`93`	`94`	`if(protocol != "http" && protocol != "https") {`
`94`	`95`	`DEBUG_HTTPCLIENT("[HTTP-Client][begin] unknown protocol '%s'\n", protocol.c_str());`
`95`	`96`	`return false;`
`@@ -137,6 +138,7 @@ bool HTTPClient::beginInternal(const String& __url, const char* expectedProtocol`
`137`	`138`	`}`
`138`	`139`
`139`	`140`	`_protocol = url.substring(0, index);`
	`141`	`+ _protocol.toLowerCase();`
`140`	`142`	`url.remove(0, (index + 3)); // remove http:// or https://`
`141`	`143`
`142`	`144`	`if (_protocol == "http") {`