Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Lint script fails because of issues in eslint-config-eslint #8

Closed
JamesHenry opened this issue Jan 15, 2016 · 2 comments · Fixed by #9
Closed

Lint script fails because of issues in eslint-config-eslint #8

JamesHenry opened this issue Jan 15, 2016 · 2 comments · Fixed by #9
Labels

Comments

@JamesHenry
Copy link
Member

I have submitted a request to have eslint-config-eslint republished to npm to include the already-merged fix: eslint/eslint#4970

I will submit a PR with the version bump to close this issue, as and when it is available.

@nzakas nzakas added bug and removed triage labels Jan 15, 2016
@JamesHenry
Copy link
Member Author

Ah, it turns out this PR eslint/eslint#4604 was merged in to eslint-config-eslint. allowAfterThis (from no-underscore-dangle rule) is therefore being used in this project, but it is an ESLint 2.x only option.

Are you happy for me to submit a PR bumping eslint-config-eslint for this project to 2.0.0 and setting eslint to 2.0.0-beta.1?

You rightly said that this project won't be a priority until 2.x is stable anyway, so we can replace the beta with stable as soon as is possible, but in the meantime it would at least allow me to lint my PRs in a future-proof way...

Also, I usually work by setting exact dependency versions (no ^ or ~), and so that is what my npm install save behaviour is by default. Would you like me to do that or stick with the "looser" definitions in PRs which require dependency changes?

@JamesHenry
Copy link
Member Author

(Sorry, didn't mean to click close)

@nzakas nzakas closed this as completed in #9 Jan 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants