Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Tests fail because of espree not being available #6

Closed
JamesHenry opened this issue Jan 15, 2016 · 5 comments
Closed

Tests fail because of espree not being available #6

JamesHenry opened this issue Jan 15, 2016 · 5 comments
Labels

Comments

@JamesHenry
Copy link
Member

I was simply trying to put together a PR to address #2, but the tests are unable to run because of espree not being available in the project.

All I did was fork the repo and run npm t

npm t

> [email protected] test /Users/james/Sites/typescript-eslint-parser
> node Makefile.js test

No coverage information was collected, exit without writing coverage information
module.js:338
    throw err;
    ^

Error: Cannot find module '../../espree'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:286:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/james/Sites/typescript-eslint-parser/tests/lib/attach-comments.js:36:14)
    at Module._compile (module.js:434:26)
    at Module._extensions..js (module.js:452:10)
    at Object.Module._extensions..js (/Users/james/Sites/typescript-eslint-parser/node_modules/istanbul/lib/hook.js:101:13)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)

...ETC...
@JamesHenry
Copy link
Member Author

Whilst this is a simple enough error, I am unclear as to whether the dependency is missing, or whether the seeming requirement for it is erroneous (as is the case for #2)

@nzakas
Copy link
Member

nzakas commented Jan 15, 2016

It shouldn't be required, that's definitely a mistake.

@nzakas
Copy link
Member

nzakas commented Feb 26, 2016

Okay, basic tests should be fixed. I don't have all of the ones we'll need eventually, but this should at least unblock further development.

@JamesHenry
Copy link
Member Author

Thanks a lot! Just to confirm, is this fixed in the sense of being runnable, or also passing?

Look forward to contributing more to this over the coming weeks!

@nzakas
Copy link
Member

nzakas commented Feb 27, 2016

Runnable. See #15. Would love some help on that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants