Missing computed flag on TSMethodSignature

[vjeux]

What version of typescript-eslint-parser are you using?
b7220fd

What code were you trying to parse?

interface Iterable<T> {
  [Symbol.iterator](): Iterator<T>;
}

What did you expect to happen?

TSMethodSignature to have computed: true

What happened?

It doesn't.

{ type: 'TSMethodSignature',
  range: [ 26, 59 ],
  loc: { start: { line: 2, column: 2 }, end: { line: 2, column: 35 } },
  transformFlags: undefined,
  modifiers: undefined,
  name:
   { type: 'MemberExpression',
     range: [ 27, 42 ],
     loc: { start: [Object], end: [Object] },
     object:
      { type: 'Identifier',
        range: [Object],
        loc: [Object],
        name: 'Symbol' },
     property:
      { type: 'Identifier',
        range: [Object],
        loc: [Object],
        name: 'iterator' },
     computed: false },
  questionToken: undefined,
  typeParameters: null,
  parameters: [],
  typeAnnotation:
   { type: 'TypeAnnotation',
     loc: { start: [Object], end: [Object] },
     range: [ 47, 58 ],
     typeAnnotation:
      { type: 'TSTypeReference',
        range: [Object],
        loc: [Object],
        transformFlags: undefined,
        typeName: [Object],
        typeParameters: [Object] } } }

So prettier prints it as

interface Iterable<T> {
  Symbol.iterator(): Iterator<T>;
}

[soda0289]

Thanks for the report.

I think this is a duplicate of #262

I have another PR #264 that should handle all these cases. I will double check this one and add a test if needed.

[vjeux]

Awesome, looks like @azz already reported the same ones as I did :P

If you want to see what's missing to get all the popular typescript projects to transpile correctly: prettier/prettier#1643 (comment)

[vjeux]

This is actually not a duplicate of #262.

var x: { [y]: any };

is now fixed, but

interface Iterable<T> {
  [Symbol.iterator](): Iterator<T>;
}

is still missing computed: true

[vjeux]

Actually, nevermind. Prettier isn't printing it -_- but it's there!

[vjeux]

Okay, there are no longer any known issues with typescript-eslint-parser from prettier. You are awesome!

[azz]

Absolutely. Thanks heaps @soda0289 and @JamesHenry!