Breaking: Updates to AST node types of some TSNodes (fixes #386)

Author: JamesHenry

README.md

@@ -67,10 +67,26 @@ Issues and pull requests will be triaged and responded to as quickly as possible
 
 ## Build Commands
 
-* `npm test` - run all linting and tests
-* `npm run lint` - run all linting
+* To run all of the linting, unit tests and AST alignment tests with Babylon:
+```
+npm test
+```
+
+* To run just the linting:
+```
+npm run lint
+```
+
+* To run just the unit tests:
+```
+npm run jest
+```
+
+* To run just the AST alignment tests with Babylon:
+```
+npm run ast-alignment-tests
+```
 
 ## License
 
 TypeScript ESLint Parser is licensed under a permissive BSD 2-clause license.
-

lib/ast-node-types.js

@@ -97,7 +97,6 @@ module.exports = {
     ThisExpression: "ThisExpression",
     ThrowStatement: "ThrowStatement",
     TryStatement: "TryStatement",
-
     /**
      * TS-prefixed nodes
      */
@@ -140,17 +139,16 @@ module.exports = {
     TSStaticKeyword: "TSStaticKeyword",
     TSStringKeyword: "TSStringKeyword",
     TSSymbolKeyword: "TSSymbolKeyword",
+    TSTypeAnnotation: "TSTypeAnnotation",
     TSTypeLiteral: "TSTypeLiteral",
+    TSTypeParameter: "TSTypeParameter",
+    TSTypeParameterDeclaration: "TSTypeParameterDeclaration",
+    TSTypeParameterInstantiation: "TSTypeParameterInstantiation",
     TSTypePredicate: "TSTypePredicate",
     TSTypeReference: "TSTypeReference",
     TSUnionType: "TSUnionType",
     TSUndefinedKeyword: "TSUndefinedKeyword",
     TSVoidKeyword: "TSVoidKeyword",
-
-    TypeAnnotation: "TypeAnnotation",
-    TypeParameter: "TypeParameter",
-    TypeParameterDeclaration: "TypeParameterDeclaration",
-    TypeParameterInstantiation: "TypeParameterInstantiation",
     UnaryExpression: "UnaryExpression",
     UpdateExpression: "UpdateExpression",
     VariableDeclaration: "VariableDeclaration",

lib/convert.js

@@ -89,7 +89,7 @@ module.exports = function convert(config) {
         const annotationStartCol = child.getFullStart() - 1;
         const loc = nodeUtils.getLocFor(annotationStartCol, child.end, ast);
         return {
-            type: AST_NODE_TYPES.TypeAnnotation,
+            type: AST_NODE_TYPES.TSTypeAnnotation,
             loc,
             range: [annotationStartCol, child.end],
             typeAnnotation: annotation
@@ -107,7 +107,7 @@ module.exports = function convert(config) {
         const greaterThanToken = nodeUtils.findNextToken(lastTypeArgument, ast);
 
         return {
-            type: AST_NODE_TYPES.TypeParameterInstantiation,
+            type: AST_NODE_TYPES.TSTypeParameterInstantiation,
             range: [
                 firstTypeArgument.pos - 1,
                 greaterThanToken.end
@@ -152,7 +152,7 @@ module.exports = function convert(config) {
         const greaterThanToken = nodeUtils.findNextToken(lastTypeParameter, ast);
 
         return {
-            type: AST_NODE_TYPES.TypeParameterDeclaration,
+            type: AST_NODE_TYPES.TSTypeParameterDeclaration,
             range: [
                 firstTypeParameter.pos - 1,
                 greaterThanToken.end
@@ -170,7 +170,7 @@ module.exports = function convert(config) {
                     : typeParameter.default;
 
                 return {
-                    type: AST_NODE_TYPES.TypeParameter,
+                    type: AST_NODE_TYPES.TSTypeParameter,
                     range: [
                         typeParameter.getStart(),
                         typeParameter.getEnd()

package.json

@@ -19,7 +19,7 @@
   "license": "BSD-2-Clause",
   "devDependencies": {
     "babel-code-frame": "^6.26.0",
-    "babylon": "7.0.0-beta.24",
+    "babylon": "^7.0.0-beta.25",
     "eslint": "4.6.1",
     "eslint-config-eslint": "4.0.0",
     "eslint-plugin-node": "5.1.1",