update behavior

Author: mysticatea

README.md

@@ -36,9 +36,12 @@ By far the most common case will be installing the [eslint-plugin-typescript](ht
 
 The following additional configuration options are available by specifying them in [`parserOptions`](https://eslint.org/docs/user-guide/configuring#specifying-parser-options) in your ESLint configuration file.
 
-**`jsx`** - default `false`. It's `true` on `*.tsx` files automatically. Enable parsing JSX when `true`. More details can be found [here](https://www.typescriptlang.org/docs/handbook/jsx.html).
+- **`jsx`** - default `false`. Enable parsing JSX when `true`. More details can be found [here](https://www.typescriptlang.org/docs/handbook/jsx.html).
+    - It's `false` on `*.ts` files regardless of this option.
+    - It's `true` on `*.tsx` files regardless of this option.
+    - Otherwise, it respects this option.
 
-**`useJSXTextNode`** - default `false`. The JSX AST changed the node type for string literals inside a JSX Element from `Literal` to `JSXText`. When value is `true`, these nodes will be parsed as type `JSXText`. When value is `false`, these nodes will be parsed as type `Literal`.
+- **`useJSXTextNode`** - default `false`. The JSX AST changed the node type for string literals inside a JSX Element from `Literal` to `JSXText`. When value is `true`, these nodes will be parsed as type `JSXText`. When value is `false`, these nodes will be parsed as type `Literal`.
 
 ### .eslintrc.json
 

parser.js

@@ -20,8 +20,11 @@ const visitorKeys = require("./visitor-keys");
 exports.version = require("./package.json").version;
 
 exports.parseForESLint = function parseForESLint(code, options) {
-    if (options && typeof options.filePath === "string" && options.filePath.endsWith(".tsx")) {
-        options = Object.assign({}, options, { jsx: true });
+    if (options && typeof options.filePath === "string") {
+        const tsx = options.filePath.endsWith(".tsx");
+        if (tsx || options.filePath.endsWith(".ts")) {
+            options = Object.assign({}, options, { jsx: tsx });
+        }
     }
 
     const ast = parse(code, options);

tests/lib/tsx.js

@@ -48,7 +48,7 @@ describe("TSX", () => {
         const linter = new Linter();
         linter.defineParser("typescript-eslint-parser", parser);
 
-        test("anonymous", () => {
+        test("filePath was not provided", () => {
             const code = "const element = <T/>";
             const config = {
                 parser: "typescript-eslint-parser"
@@ -69,6 +69,19 @@ describe("TSX", () => {
             );
         });
 
+        test("filePath was not provided and 'jsx:true' option", () => {
+            const code = "const element = <T/>";
+            const config = {
+                parser: "typescript-eslint-parser",
+                parserOptions: {
+                    jsx: true
+                }
+            };
+            const messages = linter.verify(code, config);
+
+            assert.deepStrictEqual(messages, []);
+        });
+
         test("test.ts", () => {
             const code = "const element = <T/>";
             const config = {
@@ -90,7 +103,7 @@ describe("TSX", () => {
             );
         });
 
-        test("test.ts with 'jsx' option", () => {
+        test("test.ts with 'jsx:true' option", () => {
             const code = "const element = <T/>";
             const config = {
                 parser: "typescript-eslint-parser",
@@ -100,7 +113,18 @@ describe("TSX", () => {
             };
             const messages = linter.verify(code, config, { filename: "test.ts" });
 
-            assert.deepStrictEqual(messages, []);
+            assert.deepStrictEqual(
+                messages,
+                [{
+                    column: 18,
+                    fatal: true,
+                    line: 1,
+                    message: "Parsing error: '>' expected.",
+                    ruleId: null,
+                    severity: 2,
+                    source: "const element = <T/>"
+                }]
+            );
         });
 
         test("test.tsx", () => {
@@ -112,5 +136,18 @@ describe("TSX", () => {
 
             assert.deepStrictEqual(messages, []);
         });
+
+        test("test.tsx with 'jsx:false' option", () => {
+            const code = "const element = <T/>";
+            const config = {
+                parser: "typescript-eslint-parser",
+                parserOptions: {
+                    jsx: false
+                }
+            };
+            const messages = linter.verify(code, config, { filename: "test.tsx" });
+
+            assert.deepStrictEqual(messages, []);
+        });
     });
 });