Breaking: throw syntax error on solo const keyword (fixes #531)

Author: mysticatea

package.json

@@ -63,6 +63,15 @@
     "collectCoverage": true,
     "coverageReporters": [
       "text-summary"
+    ],
+    "collectCoverageFrom": [
+      "**/*.js",
+      "!**/coverage/**",
+      "!**/node_modules/**",
+      "!**/tests/**",
+      "!**/tools/**",
+      "!**/Makefile.js",
+      "!**/test.js"
     ]
   }
 }

parser.js

@@ -13,6 +13,21 @@ const astNodeTypes = require("typescript-estree").AST_NODE_TYPES;
 const traverser = require("eslint/lib/util/traverser");
 const visitorKeys = require("./visitor-keys");
 
+/**
+ * Create a syntax error object.
+ * @param {ASTNode} node The node that caused the error.
+ * @param {string} message The error message.
+ * @returns {SyntaxError} The created error.
+ */
+function newSyntaxError(node, message) {
+    const error = new SyntaxError(message);
+    error.index = node.range[0];
+    error.lineNumber = node.loc.start.line;
+    error.column = node.loc.start.column + 1;
+
+    return error;
+}
+
 //------------------------------------------------------------------------------
 // Public
 //------------------------------------------------------------------------------
@@ -23,10 +38,30 @@ exports.parseForESLint = function parseForESLint(code, options) {
     const ast = parse(code, options);
     traverser.traverse(ast, {
         enter: node => {
-            if (node.type === "DeclareFunction" || node.type === "FunctionExpression" || node.type === "FunctionDeclaration") {
-                if (!node.body) {
-                    node.type = `TSEmptyBody${node.type}`;
-                }
+            switch (node.type) {
+                // Just for backword compatibility.
+                case "DeclareFunction":
+                    if (!node.body) {
+                        node.type = `TSEmptyBody${node.type}`;
+                    }
+                    break;
+
+                // Function#body cannot be null in ESTree spec.
+                case "FunctionExpression":
+                case "FunctionDeclaration":
+                    if (!node.body) {
+                        node.type = `TSEmptyBody${node.type}`;
+                    }
+                    break;
+
+                // VariableDeclaration that doesn't have any declarations is syntax error.
+                case "VariableDeclaration":
+                    if (node.declarations.length === 0) {
+                        throw newSyntaxError(node, `'${node.kind}' declarations require one or more declarator(s).`);
+                    }
+                    break;
+
+                // no default
             }
         }
     });

tests/fixtures/basics/solo-const.src.js

@@ -0,0 +1 @@
+const

tests/lib/__snapshots__/basics.js.snap

@@ -2162,6 +2162,8 @@ Object {
 }
 `;
 
+exports[`basics fixtures/solo-const.src 1`] = `"'const' declarations require one or more declarator(s)."`;
+
 exports[`basics fixtures/typeof-expression.src 1`] = `
 Object {
   "body": Array [