Skip to content

Commit 75acdd2

Browse files
authored
chore: lint more js files in docs (#16964)
* chore: lint more js files in docs * removed unused disable directive
1 parent 3398431 commit 75acdd2

File tree

6 files changed

+31
-17
lines changed

6 files changed

+31
-17
lines changed

.eslintignore

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
/build/**
22
/coverage/**
3-
/docs/**
4-
!/docs/.eleventy.js
3+
/docs/*
4+
!/docs/*.js
5+
!/docs/tools/
56
/jsdoc/**
67
/templates/**
78
/tests/bench/**

.eslintrc.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,10 @@ module.exports = {
8383
},
8484
overrides: [
8585
{
86-
files: ["tools/*.js"],
86+
files: ["tools/*.js", "docs/tools/*.js"],
8787
rules: {
88-
"no-console": "off"
88+
"no-console": "off",
89+
"n/no-process-exit": "off"
8990
}
9091
},
9192
{

docs/postcss.config.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1+
"use strict";
2+
13
module.exports = {
24
plugins: [
3-
require('autoprefixer'),
4-
require('cssnano')
5+
require("autoprefixer"),
6+
require("cssnano")
57
],
68
map: false
7-
}
9+
};

docs/tools/validate-links.js

+14-6
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
"use strict";
2+
13
const path = require("path");
24
const TapRender = require("@munter/tap-render");
35
const spot = require("tap-spot");
@@ -16,13 +18,19 @@ const skipPatterns = [
1618
"/team",
1719
"/donate",
1820
"/docs/latest",
19-
`src="null"`,
21+
'src="null"'
2022
];
2123

22-
const skipFilter = (report) =>
23-
Object.values(report).some((value) =>
24-
skipPatterns.some((pattern) => String(value).includes(pattern))
25-
);
24+
/**
25+
* Filter function to mark tests as skipped.
26+
* Tests for which this function returns `true' are not considered failed.
27+
* @param {Object} report hyperlink's test report for a link.
28+
* @returns {boolean} `true` if the report contains any of `skipPatterns`.
29+
*/
30+
function skipFilter(report) {
31+
return Object.values(report).some(value =>
32+
skipPatterns.some(pattern => String(value).includes(pattern)));
33+
}
2634

2735
(async () => {
2836
try {
@@ -35,7 +43,7 @@ const skipFilter = (report) =>
3543
internalOnly: true,
3644
pretty: true,
3745
concurrency: 25,
38-
skipFilter,
46+
skipFilter
3947
},
4048
tapRenderInstance
4149
);

eslint.config.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ module.exports = [
8585
"build/**",
8686
"coverage/**",
8787
"docs/*",
88-
"!docs/.eleventy.js",
88+
"!docs/*.js",
89+
"!docs/tools/",
8990
"jsdoc/**",
9091
"templates/**",
9192
"tests/bench/**",
@@ -119,9 +120,10 @@ module.exports = [
119120
}
120121
},
121122
{
122-
files: ["tools/*.js"],
123+
files: ["tools/*.js", "docs/tools/*.js"],
123124
rules: {
124-
"no-console": "off"
125+
"no-console": "off",
126+
"n/no-process-exit": "off"
125127
}
126128
},
127129
{

tools/fetch-docs-links.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ async function fetchLinkMeta(url) {
9999
console.error("Could not fetch data for", url);
100100
console.error(ex.message);
101101
console.error(ex.stack);
102-
process.exit(1); // eslint-disable-line n/no-process-exit -- used in tools
102+
process.exit(1);
103103
}
104104
}
105105
}

0 commit comments

Comments
 (0)