style: update linting

Author: RebeccaStevens

.eslintrc.json

@@ -101,6 +101,8 @@
         "@typescript-eslint/no-explicit-any": "off",
         "@typescript-eslint/no-unused-expressions": "off",
         "@typescript-eslint/no-unused-vars": "off",
+        "@typescript-eslint/prefer-function-type": "off",
+        "@typescript-eslint/consistent-generic-constructors": "off",
         "import/no-unresolved": "off",
         "init-declarations": "off",
         "jsdoc/require-jsdoc": "off",

knip.jsonc

@@ -4,5 +4,6 @@
   "project": ["src/**/*.ts!", "tests/**/*.ts", "cz-adapter/**/*.ts"],
   "ignoreDependencies": [
     "@typescript-eslint/eslint-plugin-disable-type-checked"
-  ]
+  ],
+  "ignore": ["tests/fixture/file.ts"]
 }

src/rules/no-expression-statements.ts

@@ -103,7 +103,7 @@ function checkExpressionStatement(
 
   const { ignoreVoid } = optionsObject;
 
-  if (ignoreVoid === true) {
+  if (ignoreVoid) {
     const type = getTypeOfNode(node.expression, context);
 
     return {

src/rules/no-mixed-types.ts

@@ -173,7 +173,7 @@ export const rule = createRuleUsingFunction<
 >(name, meta, defaultOptions, (context, options) => {
   const [{ checkInterfaces, checkTypeLiterals }] = options;
 
-  return Object.fromEntries<any>(
+  return Object.fromEntries(
     (
       [
         [
@@ -186,5 +186,5 @@ export const rule = createRuleUsingFunction<
         ],
       ] as const
     ).filter(([sel, fn]) => fn !== undefined),
-  );
+  ) as Record<string, any>;
 });

src/rules/prefer-readonly-type.ts

@@ -207,7 +207,7 @@ function checkArrayOrTupleType(
 
   if (
     shouldIgnoreClasses(node, context, ignoreClass) ||
-    (ignoreInterface === true && isInInterface(node)) ||
+    (ignoreInterface && isInInterface(node)) ||
     shouldIgnoreInFunction(node, context, allowLocalMutation) ||
     shouldIgnorePattern2(node, context, ignorePattern) ||
     ignoreCollections
@@ -263,7 +263,7 @@ function checkMappedType(
 
   if (
     shouldIgnoreClasses(node, context, ignoreClass) ||
-    (ignoreInterface === true && isInInterface(node)) ||
+    (ignoreInterface && isInInterface(node)) ||
     shouldIgnoreInFunction(node, context, allowLocalMutation) ||
     shouldIgnorePattern2(node, context, ignorePattern)
   ) {
@@ -312,7 +312,7 @@ function checkTypeReference(
 
   if (
     shouldIgnoreClasses(node, context, ignoreClass) ||
-    (ignoreInterface === true && isInInterface(node)) ||
+    (ignoreInterface && isInInterface(node)) ||
     shouldIgnoreInFunction(node, context, allowLocalMutation) ||
     shouldIgnorePattern2(node, context, ignorePattern)
   ) {
@@ -379,7 +379,7 @@ function checkProperty(
 
   if (
     shouldIgnoreClasses(node, context, ignoreClass) ||
-    (ignoreInterface === true && isInInterface(node)) ||
+    (ignoreInterface && isInInterface(node)) ||
     shouldIgnoreInFunction(node, context, allowLocalMutation) ||
     shouldIgnorePattern2(node, context, ignorePattern)
   ) {
@@ -392,8 +392,7 @@ function checkProperty(
   return {
     context,
     descriptors:
-      node.readonly !== true &&
-      (!allowMutableReturnType || !isInReturnType(node))
+      !node.readonly && (!allowMutableReturnType || !isInReturnType(node))
         ? [
             {
               node,
@@ -444,7 +443,7 @@ function checkImplicitType(
   if (
     !checkImplicit ||
     shouldIgnoreClasses(node, context, ignoreClass) ||
-    (ignoreInterface === true && isInInterface(node)) ||
+    (ignoreInterface && isInInterface(node)) ||
     shouldIgnoreInFunction(node, context, allowLocalMutation) ||
     shouldIgnorePattern2(node, context, ignorePattern)
   ) {

src/settings/immutability.ts

@@ -31,10 +31,10 @@ declare module "@typescript-eslint/utils" {
 /**
  * The settings that have been loaded - so we don't have to reload them.
  */
-const cachedSettings: WeakMap<
+const cachedSettings = new WeakMap<
   NonNullable<SharedConfigurationSettings["immutability"]>,
   ImmutabilityOverrides | undefined
-> = new WeakMap();
+>();
 
 /**
  * Get the immutability overrides defined in the settings.

tests/helpers/util.ts

@@ -7,7 +7,6 @@ import {
   type ValidTestCase,
   type InvalidTestCase,
   type RunTests,
-  type RuleListener,
 } from "@typescript-eslint/utils/ts-eslint";
 
 import ts from "~/conditional-imports/typescript";