add "window" as default

Author: gurgunday

__tests__/always-return.js

@@ -105,14 +105,19 @@ ruleTester.run('always-return', rule, {
         .finally(() => console.error('end'))`,
       options: [{ ignoreLastCallback: true }],
     },
-    {
-      code: `hey.then(x => { window.a = x })`,
-      options: [{ ignoreAssignmentVariable: ['window'] }],
-    },
+    `hey.then(x => { window.a = x })`,
     {
       code: `hey.then(x => { window.a.x = x })`,
       options: [{ ignoreAssignmentVariable: ['window.a'] }],
     },
+    {
+      code: `hey.then(x => { globalThis.a = x })`,
+      options: [{ ignoreAssignmentVariable: ['globalThis'] }],
+    },
+    {
+      code: `hey.then(x => { globalThis.a.x = x })`,
+      options: [{ ignoreAssignmentVariable: ['globalThis.a'] }],
+    },
   ],
 
   invalid: [

docs/rules/always-return.md

@@ -98,23 +98,33 @@ function foo() {
 You can pass an `{ ignoreAssignmentVariable: [] }` as an option to this rule
 with a list of variable names so that the last `then()` callback in a promise
 chain does not warn if it does an assignment to a global variable. Default is
-`[]`.
+`["window"]`.
 
 ```js
-/* eslint promise/always-return: ["error", { ignoreAssignmentVariable: ["window"] }] */
+/* eslint promise/always-return: ["error", { ignoreAssignmentVariable: ["globalThis", "globalThis.modules"] }] */
 
 // OK
 promise.then((x) => {
   window.x = x
 })
 
-promise
-  // NG
-  .then((x) => {
-    window.x.y = x
-  })
-  // NG
-  .then((x) => {
-    let b = x
-  })
+// OK
+promise.then((x) => {
+  globalThis.x = x
+})
+
+// OK
+promise.then((x) => {
+  globalThis.modules.x = x
+})
+
+// NG
+promise.then((x) => {
+  window.x.y = x
+})
+
+// NG
+promise.then((x) => {
+  let a = x
+})
 ```

rules/always-return.js

@@ -185,7 +185,9 @@ module.exports = {
   create(context) {
     const options = context.options[0] || {}
     const ignoreLastCallback = !!options.ignoreLastCallback
-    const ignoreAssignmentVariable = options.ignoreAssignmentVariable || []
+    const ignoreAssignmentVariable = options.ignoreAssignmentVariable || [
+      'window',
+    ]
     /**
      * @typedef {object} FuncInfo
      * @property {string[]} branchIDStack This is a stack representing the currently