From 5473e50bcd9ad0963e0d7882f1234a3c586e86d5 Mon Sep 17 00:00:00 2001 From: "weiran.zsd" Date: Thu, 25 Oct 2018 04:25:45 +0800 Subject: [PATCH] Fix: no-deprecated-report-api should consider spread operator(fixes #64) --- lib/rules/no-deprecated-report-api.js | 2 +- tests/lib/rules/no-deprecated-report-api.js | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/rules/no-deprecated-report-api.js b/lib/rules/no-deprecated-report-api.js index 58b31a39..655d6108 100644 --- a/lib/rules/no-deprecated-report-api.js +++ b/lib/rules/no-deprecated-report-api.js @@ -39,7 +39,7 @@ module.exports = { node.callee.type === 'MemberExpression' && contextIdentifiers.has(node.callee.object) && node.callee.property.type === 'Identifier' && node.callee.property.name === 'report' && - node.arguments.length > 1 + (node.arguments.length > 1 || (node.arguments.length === 1 && node.arguments[0].type === 'SpreadElement')) ) { context.report({ node: node.callee.property, diff --git a/tests/lib/rules/no-deprecated-report-api.js b/tests/lib/rules/no-deprecated-report-api.js index e5e3559b..b46043c7 100644 --- a/tests/lib/rules/no-deprecated-report-api.js +++ b/tests/lib/rules/no-deprecated-report-api.js @@ -209,5 +209,16 @@ ruleTester.run('no-deprecated-report-api', rule, { output: null, errors: [ERROR], }, + { + code: ` + module.exports = { + create(context) { + context.report(...error); + } + }; + `, + output: null, + errors: [ERROR], + }, ], });