We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coming over from typescript-eslint/typescript-eslint#8226 -> typescript-eslint/typescript-eslint#9261: amusingly+ironically, the eslint-plugin/no-property-in-node rules doesn't detect any types in the https://github.com/typescript-eslint/typescript-eslint codebase. This is because typescript-eslint's types are defined at a path like:
eslint-plugin/no-property-in-node
/Users/josh/repos/typescript-eslint/packages/types/dist/generated/ast-spec.d.ts
...while the rule only checks node_modules/ style paths:
node_modules/
eslint-plugin-eslint-plugin/lib/rules/no-property-in-node.js
Lines 3 to 6 in 04e397b
I suppose we have two possible fixes:
/packages[/\\]types[/\\]dist[/\\]generated[/\\]ast-spec\.d\.ts/,
Proposal: can we go for the latter fix, adding a rule option? I feel awkward asking to hardcode this rule for one project. 😄
The text was updated successfully, but these errors were encountered:
I also agreed to adding an option.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Coming over from typescript-eslint/typescript-eslint#8226 -> typescript-eslint/typescript-eslint#9261: amusingly+ironically, the
eslint-plugin/no-property-in-node
rules doesn't detect any types in the https://github.com/typescript-eslint/typescript-eslint codebase. This is because typescript-eslint's types are defined at a path like:...while the rule only checks
node_modules/
style paths:eslint-plugin-eslint-plugin/lib/rules/no-property-in-node.js
Lines 3 to 6 in 04e397b
I suppose we have two possible fixes:
/packages[/\\]types[/\\]dist[/\\]generated[/\\]ast-spec\.d\.ts/,
to hardcode for typescript-eslintProposal: can we go for the latter fix, adding a rule option? I feel awkward asking to hardcode this rule for one project. 😄
The text was updated successfully, but these errors were encountered: