Fix: Correctly handle rules that are missing meta or have meta / create defined in variables
#225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
rules-without-meta
branch
from
b240cc1 to
0534276
Compare
bmish
force-pushed
the
rules-without-meta
branch
4 times, most recently
from
a377956 to
1d02934
Compare
…`create` defined in variables
bmish
force-pushed
the
rules-without-meta
branch
from
1d02934 to
293a350
Compare
bmish
commented
Oct 25, 2021
| * @param {ScopeManager} scopeManager The scope manager to use for resolving references | ||
| * @returns {boolean} `true` if the node is a reference to a function expression | ||
| */ | ||
| function isNormalFunctionExpressionReference (node, scopeManager) { |
There was a problem hiding this comment.
I'm very happy to be able to remove this overly-complicated function. I have been able to dramatically simplify the code using my new findVariableValue function.
|
Side note: ready for a patch release after this is merged. |
This was referenced Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, many of our rules using our
getRuleInfoutil (especially therequire-meta-*rules) had inconsistent behavior when encountering a rule that was missingmetaor using variables formeta/create).Example structures:
These are two very closed-related / overlapping issues so I fixed them together and added a variety of tests.
This addresses some crashes / false negatives / false positives.
Fixes #181.