Skip to content

Breaking: report-message-format should apply to suggestion messages #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #120
bmish opened this issue Sep 25, 2021 · 0 comments · Fixed by #195
Closed
Tracked by #120

Breaking: report-message-format should apply to suggestion messages #192

bmish opened this issue Sep 25, 2021 · 0 comments · Fixed by #195

Comments

@bmish
Copy link
Member

bmish commented Sep 25, 2021 •
edited
Loading

The report-message-format only applies to violation messages, but not suggestion messages.

As a breaking change, we should update it to apply to both violation and suggestion messages.

report-message-format: ['error', '^[A-Z].*\\.$']

As a follow-up (non-breaking change), we could add object-based options to the rule to allow separate violation/suggestion message requirements:

report-message-format: ['error', { error: '^[A-Z].*\\.$', suggestion: '^[A-Z].*\\.$' }]
@bmish bmish mentioned this issue Sep 25, 2021
Closed
20 tasks
@bmish bmish changed the title report-message-format should have option added to support suggestion messages Breaking: report-message-format should apply to suggestion messages Sep 26, 2021
@bmish bmish mentioned this issue Sep 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bmish