Skip to content

require-meta-schema should only autofix when no options present #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bmish opened this issue Sep 24, 2021 · 1 comment · Fixed by #184
Closed

require-meta-schema should only autofix when no options present #182

bmish opened this issue Sep 24, 2021 · 1 comment · Fixed by #184

Comments

@bmish
Copy link
Member

bmish commented Sep 24, 2021 •
edited
Loading

The goal is that the rule should only autofix to schema: [] if no options are used.

Originally posted by @bmish in #180 (comment)
@aladdin-add
Copy link
Contributor

aladdin-add commented Sep 24, 2021 •
edited
Loading

the autofix will introduce a breaking change for users when passing unknown options:

before autofix: skip validating and lint working fine.
after autofix: an error thrown from eslint.

This was referenced Sep 24, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bmish @aladdin-add