Fix: Avoid crash with non-static value of hasSuggestions in require-meta-has-suggestion rule

Author: bmish

lib/rules/require-meta-has-suggestions.js

@@ -65,11 +65,11 @@ module.exports = {
           if (!hasSuggestionsProperty) {
             // Rule reports suggestions but is missing the `meta.hasSuggestions` property altogether.
             context.report({ node: metaNode ? metaNode : ruleInfo.create, messageId: 'shouldBeSuggestable' });
-          } else if (hasSuggestionsStaticValue.value !== true) {
+          } else if (hasSuggestionsStaticValue && hasSuggestionsStaticValue.value !== true) {
             // Rule reports suggestions but does not have `meta.hasSuggestions` property enabled.
             context.report({ node: hasSuggestionsProperty.value, messageId: 'shouldBeSuggestable' });
           }
-        } else if (!ruleReportsSuggestions && hasSuggestionsProperty && hasSuggestionsStaticValue.value === true) {
+        } else if (!ruleReportsSuggestions && hasSuggestionsProperty && hasSuggestionsStaticValue && hasSuggestionsStaticValue.value === true) {
           // Rule does not report suggestions but has the `meta.hasSuggestions` property enabled.
           context.report({ node: hasSuggestionsProperty.value, messageId: 'shouldNotBeSuggestable' });
         }

tests/lib/rules/require-meta-has-suggestions.js

@@ -112,6 +112,34 @@ ruleTester.run('require-meta-has-suggestions', rule, {
         }
       };
     `,
+    // Provides suggestions, has hasSuggestions property with no static value available.
+    `
+      module.exports = {
+        meta: { hasSuggestions: getHasSuggestions() },
+        create(context) {
+          context.report({node, message, suggest: [{}]});
+        }
+      };
+    `,
+    // Provides suggestions, has hasSuggestions property in variable with no static value available
+    `
+      const hasSuggestions = getHasSuggestions();
+      module.exports = {
+        meta: { hasSuggestions },
+        create(context) {
+          context.report({node, message, suggest: [{}]});
+        }
+      };
+    `,
+    // Does not provide suggestions, has hasSuggestions property with no static value available
+    `
+      module.exports = {
+        meta: { hasSuggestions: getHasSuggestions() },
+        create(context) {
+          context.report({node, message});
+        }
+      };
+    `,
     // Spread syntax.
     {
       code: `