Update: add fixer for test-case-shorthand-strings

Author: not-an-aardvark

Diff for: lib/rules/test-case-shorthand-strings.js

@@ -19,10 +19,13 @@ module.exports = {
       recommended: false,
     },
     schema: [{ enum: ['as-needed', 'never', 'consistent', 'consistent-as-needed'] }],
+    fixable: 'code',
   },
 
   create (context) {
     const shorthandOption = context.options[0] || 'as-needed';
+    const sourceCode = context.getSourceCode();
+
     // ----------------------------------------------------------------------
     // Helpers
     // ----------------------------------------------------------------------
@@ -63,6 +66,14 @@ module.exports = {
             preferred: badCaseInfo.shorthand ? 'an object' : 'a string',
             actual: badCaseInfo.shorthand ? 'a string' : 'an object',
           },
+          fix (fixer) {
+            return fixer.replaceText(
+              badCaseInfo.node,
+              badCaseInfo.shorthand
+                ? `{code: ${sourceCode.getText(badCaseInfo.node)}}`
+                : sourceCode.getText(badCaseInfo.node.properties[0].value)
+            );
+          },
         });
       });
     }

Diff for: tests/lib/rules/test-case-shorthand-strings.js

@@ -126,71 +126,79 @@ ruleTester.run('test-case-shorthand-strings', rule, {
     // as-needed
     {
       code: getTestCases(['{ code: "foo" }']),
+      output: getTestCases(['"foo"']),
       errors: [EXPECTED_SHORTHAND_ERROR],
     },
     {
       code: getTestCases(['{ code: `foo` }']),
+      output: getTestCases(['`foo`']),
       errors: [EXPECTED_SHORTHAND_ERROR],
     },
     {
       code: getTestCases(['"foo"', '{ code: `foo` }']),
+      output: getTestCases(['"foo"', '`foo`']),
       errors: [EXPECTED_SHORTHAND_ERROR],
     },
     {
       code: getTestCases(['"foo"', '{ code: "foo" }', '{ code: `bar` }']),
+      output: getTestCases(['"foo"', '"foo"', '`bar`']),
       errors: [EXPECTED_SHORTHAND_ERROR, EXPECTED_SHORTHAND_ERROR],
     },
 
     // never
     {
       code: getTestCases(['"foo"']),
+      output: getTestCases(['{code: "foo"}']),
       options: ['never'],
       errors: [UNEXPECTED_SHORTHAND_ERROR],
     },
     {
       code: getTestCases(['foo', '"bar"']),
-      options: ['never'],
-      errors: [UNEXPECTED_SHORTHAND_ERROR],
-    },
-    {
-      code: getTestCases(['foo', '"bar"']),
+      output: getTestCases(['foo', '{code: "bar"}']),
       options: ['never'],
       errors: [UNEXPECTED_SHORTHAND_ERROR],
     },
     {
       code: getTestCases(['`foo`']),
+      output: getTestCases(['{code: `foo`}']),
       options: ['never'],
       errors: [UNEXPECTED_SHORTHAND_ERROR],
     },
     {
       code: getTestCases(['"foo"']) + getTestCases(['"foo"']),
+      output: getTestCases(['{code: "foo"}']) + getTestCases(['{code: "foo"}']),
       options: ['never'],
       errors: [UNEXPECTED_SHORTHAND_ERROR, UNEXPECTED_SHORTHAND_ERROR],
     },
 
     // consistent
     {
       code: getTestCases(['"foo"', '{ code: "bar" }', '{ code: "baz" }']),
+      output: getTestCases(['"foo"', '"bar"', '"baz"']),
       errors: [EXPECTED_SHORTHAND_ERROR, EXPECTED_SHORTHAND_ERROR],
     },
     {
       code: getTestCases(['{ code: "bar" }', '"foo"', '{ code: "baz" }']),
+      output: getTestCases(['"bar"', '"foo"', '"baz"']),
       errors: [EXPECTED_SHORTHAND_ERROR, EXPECTED_SHORTHAND_ERROR],
     },
 
     // consistent-as-needed
     {
       code: getTestCases(['{ code: "foo" }', '{ code: "bar" }']),
+      output: getTestCases(['"foo"', '"bar"']),
       options: ['consistent-as-needed'],
       errors: [EXPECTED_SHORTHAND_ERROR, EXPECTED_SHORTHAND_ERROR],
     },
     {
       code: getTestCases(['"foo"', '"bar"', '{ code: "baz", options: ["foo"] }']),
+      output: getTestCases(['{code: "foo"}', '{code: "bar"}', '{ code: "baz", options: ["foo"] }']),
       options: ['consistent-as-needed'],
       errors: [UNEXPECTED_SHORTHAND_ERROR, UNEXPECTED_SHORTHAND_ERROR],
     },
     {
       code: getTestCases(['"foo"', '{ code: "baz", options: ["foo"] }', '"bar"']),
+      output: getTestCases(['{code: "foo"}', '{ code: "baz", options: ["foo"] }', '{code: "bar"}']),
       options: ['consistent-as-needed'],
       errors: [UNEXPECTED_SHORTHAND_ERROR, UNEXPECTED_SHORTHAND_ERROR],
     },