Breaking: Add fixer-return to rules preset (#199)

All rules should have a category of either `Rules` or `Tests` since this is how those presets are generated.

Author: bmish

lib/rules/fixer-return.js

@@ -21,7 +21,7 @@ module.exports = {
     type: 'problem',
     docs: {
       description: 'require fixer functions to return a fix',
-      category: 'Possible Errors',
+      category: 'Rules',
       recommended: true,
     },
     fixable: null,

tests/lib/rule-setup.js

@@ -37,6 +37,18 @@ describe('rule setup is correct', () => {
     );
   });
 
+  describe('rule files', () => {
+    for (const ruleName of RULE_NAMES) {
+      const rule = plugin.rules[ruleName];
+      describe(ruleName, () => {
+        it('has the right properties', () => {
+          const ALLOWED_CATEGORIES = ['Rules', 'Tests'];
+          assert.ok(ALLOWED_CATEGORIES.includes(rule.meta.docs.category), 'has an allowed category');
+        });
+      });
+    }
+  });
+
   it('should have tests for all rules', () => {
     const filePath = path.join(__dirname, 'rules');
     const files = readdirSync(filePath);