Skip to content

Commit 5f8dbd8

Browse files
Chore: refactor utils.getRuleInfo
1 parent f32ada6 commit 5f8dbd8

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

lib/utils.js

+5-10
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ module.exports = {
2020
from the file, the return value will be `null`.
2121
*/
2222
getRuleInfo (ast) {
23-
const INTERESTING_KEYS = ['create', 'meta'];
23+
const INTERESTING_KEYS = new Set(['create', 'meta']);
2424
let exportsVarOverridden = false;
2525
let exportsIsFunction = false;
2626

@@ -46,13 +46,8 @@ module.exports = {
4646

4747
exportsIsFunction = false;
4848
return node.right.properties.reduce((parsedProps, prop) => {
49-
const keyValue = prop.key.type === 'Literal'
50-
? prop.key.value
51-
: prop.key.type === 'Identifier'
52-
? prop.key.name
53-
: null;
54-
55-
if (INTERESTING_KEYS.indexOf(keyValue) !== -1) {
49+
const keyValue = module.exports.getKeyName(prop);
50+
if (INTERESTING_KEYS.has(keyValue)) {
5651
parsedProps[keyValue] = prop.value;
5752
}
5853
return parsedProps;
@@ -64,15 +59,15 @@ module.exports = {
6459
node.left.object.type === 'MemberExpression' &&
6560
node.left.object.object.type === 'Identifier' && node.left.object.object.name === 'module' &&
6661
node.left.object.property.type === 'Identifier' && node.left.object.property.name === 'exports' &&
67-
node.left.property.type === 'Identifier' && INTERESTING_KEYS.indexOf(node.left.property.name) !== -1
62+
node.left.property.type === 'Identifier' && INTERESTING_KEYS.has(node.left.property.name)
6863
) {
6964
// Check `module.exports.create = () => {}`
7065

7166
currentExports[node.left.property.name] = node.right;
7267
} else if (
7368
!exportsVarOverridden &&
7469
node.left.object.type === 'Identifier' && node.left.object.name === 'exports' &&
75-
node.left.property.type === 'Identifier' && INTERESTING_KEYS.indexOf(node.left.property.name) !== -1
70+
node.left.property.type === 'Identifier' && INTERESTING_KEYS.has(node.left.property.name)
7671
) {
7772
// Check `exports.create = () => {}`
7873

0 commit comments

Comments
 (0)