Update: no-identical-tests despite of properties order.

Author: aladdin-add

lib/rules/no-identical-tests.js

@@ -29,15 +29,46 @@ module.exports = {
     const message = 'This test case is identical to another case.';
     const sourceCode = context.getSourceCode();
 
+    // ----------------------------------------------------------------------
+    // Helpers
+    // ----------------------------------------------------------------------
+    /**
+     *compare two test cases depite of properties order.
+     *@returns {boolean} if eq, return true, else return false.
+    */
+    function eq (ta, tb) {
+      const pa = ta.properties || [];
+      const pb = tb.properties || [];
+
+      // if properties length not eq; return false;
+      if (pa.length !== pb.length) {
+        return false;
+      }
+
+      // convert array to object
+      const paObj = pa.reduce((result, item) => {
+        const code = sourceCode.getText(item);
+        result[code] = true;
+        return result;
+      }, {});
+
+      for (let i = 0; i < pb.length; i++) {
+        const code = sourceCode.getText(pb[i]);
+        if (!(code in paObj)) {
+          return false;
+        }
+      }
+      return true;
+    }
+
     return {
       Program (ast) {
         utils.getTestInfo(context, ast).forEach(testRun => {
           [testRun.valid, testRun.invalid].forEach(tests => {
-            const cache = Object.create(null);
+            const cache = [];
             // to avoid tests being null
             (tests || []).forEach(test => {
-              const testCode = sourceCode.getText(test);
-              if (cache[testCode]) {
+              if (cache.some(item => eq(item, test))) {
                 context.report({
                   node: test,
                   message,
@@ -50,7 +81,7 @@ module.exports = {
                   },
                 });
               } else {
-                cache[testCode] = true;
+                cache.push(test);
               }
             });
           });

tests/lib/rules/no-identical-tests.js

@@ -106,5 +106,25 @@ ruleTester.run('no-identical-tests', rule, {
         });
       `,
     },
+    {
+      code: `
+        new RuleTester().run('foo', bar, {
+          valid: [
+            { code: 'foo', options: ['bar'] },
+            { options: ['bar'], code: 'foo' },
+          ],
+          invalid: []
+        });
+      `,
+      errors: [ERROR],
+      output: `
+        new RuleTester().run('foo', bar, {
+          valid: [
+            { code: 'foo', options: ['bar'] },
+          ],
+          invalid: []
+        });
+      `,
+    },
   ],
 });