Fixing constants

Author: leandrodamascena

aws_lambda_powertools/utilities/feature_flags/comparators.py

@@ -5,7 +5,8 @@
 
 from dateutil.tz import gettz
 
-from aws_lambda_powertools.utilities.feature_flags.schema import HOUR_MIN_SEPARATOR, ModuloRangeValues, TimeValues
+from aws_lambda_powertools.utilities.feature_flags.constants import HOUR_MIN_SEPARATOR
+from aws_lambda_powertools.utilities.feature_flags.schema import ModuloRangeValues, TimeValues
 
 
 def _get_now_from_timezone(timezone: tzinfo | None) -> datetime:

aws_lambda_powertools/utilities/feature_flags/constants.py

@@ -0,0 +1,13 @@
+import re
+
+RULES_KEY = "rules"
+FEATURE_DEFAULT_VAL_KEY = "default"
+CONDITIONS_KEY = "conditions"
+RULE_MATCH_VALUE = "when_match"
+CONDITION_KEY = "key"
+CONDITION_VALUE = "value"
+CONDITION_ACTION = "action"
+FEATURE_DEFAULT_VAL_TYPE_KEY = "boolean_type"
+TIME_RANGE_FORMAT = "%H:%M"  # hour:min 24 hours clock
+TIME_RANGE_PATTERN = re.compile(r"2[0-3]:[0-5]\d|[0-1]\d:[0-5]\d")  # 24 hour clock
+HOUR_MIN_SEPARATOR = ":"

aws_lambda_powertools/utilities/feature_flags/exceptions.py

@@ -7,7 +7,7 @@ class SchemaValidationError(Exception):
 
 
 class StoreClientError(Exception):
-    """When a store raises an exception that should be propagated to the client to fix
+    """When a store raises an exception that should be propagated to the client
 
     For example, Access Denied errors when the client doesn't permissions to fetch config
     """

aws_lambda_powertools/utilities/feature_flags/feature_flags.py

@@ -1,9 +1,7 @@
 from __future__ import annotations
 
 import logging
-from typing import TYPE_CHECKING, Any, Callable, TypeVar, cast
-
-from typing_extensions import ParamSpec
+from typing import TYPE_CHECKING, Any, Callable, cast
 
 from aws_lambda_powertools.utilities.feature_flags import schema
 from aws_lambda_powertools.utilities.feature_flags.comparators import (
@@ -16,14 +14,13 @@
     compare_time_range,
 )
 from aws_lambda_powertools.utilities.feature_flags.exceptions import ConfigurationStoreError
+from aws_lambda_powertools.utilities.feature_flags.types import P, T
 
 if TYPE_CHECKING:
     from aws_lambda_powertools.logging import Logger
     from aws_lambda_powertools.utilities.feature_flags.base import StoreProvider
     from aws_lambda_powertools.utilities.feature_flags.types import JSONType
 
-T = TypeVar("T")
-P = ParamSpec("P")
 
 RULE_ACTION_MAPPING = {
     schema.RuleAction.EQUALS.value: lambda a, b: a == b,

aws_lambda_powertools/utilities/feature_flags/schema.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 
 import logging
-import re
 from datetime import datetime
 from enum import Enum
 from functools import lru_cache
@@ -15,17 +14,18 @@
 if TYPE_CHECKING:
     from aws_lambda_powertools.logging import Logger
 
-RULES_KEY = "rules"
-FEATURE_DEFAULT_VAL_KEY = "default"
-CONDITIONS_KEY = "conditions"
-RULE_MATCH_VALUE = "when_match"
-CONDITION_KEY = "key"
-CONDITION_VALUE = "value"
-CONDITION_ACTION = "action"
-FEATURE_DEFAULT_VAL_TYPE_KEY = "boolean_type"
-TIME_RANGE_FORMAT = "%H:%M"  # hour:min 24 hours clock
-TIME_RANGE_PATTERN = re.compile(r"2[0-3]:[0-5]\d|[0-1]\d:[0-5]\d")  # 24 hour clock
-HOUR_MIN_SEPARATOR = ":"
+from aws_lambda_powertools.utilities.feature_flags.constants import (
+    CONDITION_ACTION,
+    CONDITION_KEY,
+    CONDITION_VALUE,
+    CONDITIONS_KEY,
+    FEATURE_DEFAULT_VAL_KEY,
+    FEATURE_DEFAULT_VAL_TYPE_KEY,
+    RULE_MATCH_VALUE,
+    RULES_KEY,
+    TIME_RANGE_FORMAT,
+    TIME_RANGE_PATTERN,
+)
 
 LOGGER: logging.Logger | Logger = logging.getLogger(__name__)
 

aws_lambda_powertools/utilities/feature_flags/types.py

@@ -1,6 +1,10 @@
 from __future__ import annotations
 
-from typing import Any
+from typing import Any, TypeVar
+
+from typing_extensions import ParamSpec
 
 # JSON primitives only, mypy doesn't support recursive tho
 JSONType = str | int | float | bool | None | dict[str, Any] | list[Any]
+T = TypeVar("T")
+P = ParamSpec("P")