Skip to content

Commit 76e8cf3

Browse files
committed
[serverless-python-requirements] Make plugin compatible with version 6.0.0
With version `6.0.0` of `serverless-python-requirements` they switched to use official AWS docker images. More info can be found in serverless/serverless-python-requirements#724 So we don’t need `lambci/lambda` anymore. With this change everyone who is using `serverless-python-requirements` plugin and will update `serverless-builder`, would have to upgrade `serverless-python-requirements` itself. I was considering two less breaking change approach like: 1. Introduce new plugin class ``` class PythonRequirements600 { } ``` 2. Modification of `PythonRequirements.__init__` and add `version` parameter But to be honest I don’t think it’s worth to maintain this backward compatibility.
1 parent 6b4546f commit 76e8cf3

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

serverless/service/plugins/python_requirements.py

-3
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,4 @@ def enable(self, service):
3434
export = dict(self)
3535
export.pop("name", None)
3636

37-
if not export.get("dockerImage"):
38-
export["dockerImage"] = f"lambci/lambda:build-{service.provider.runtime}"
39-
4037
service.custom.pythonRequirements = export

0 commit comments

Comments
 (0)