Skip to content

Commit ce9873f

Browse files
authored
Upgrade dtslint (#2653)
* Upgrade dtslint * Fix dtslint errors
1 parent 29c99a9 commit ce9873f

33 files changed

+246
-175
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@
213213
"bundlesize": "^0.13.2",
214214
"codecov": "^2.3.1",
215215
"cssjanus": "^1.2.0",
216-
"dtslint": "^0.3.0",
216+
"dtslint": "^4.2.1",
217217
"enzyme": "^3.11.0",
218218
"enzyme-adapter-react-16": "^1.15.5",
219219
"enzyme-to-json": "^3.6.1",

packages/cache/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@
2323
},
2424
"devDependencies": {
2525
"@emotion/hash": "*",
26-
"dtslint": "^0.3.0"
26+
"dtslint": "^4.2.1",
27+
"typescript": "^4.5.5"
2728
},
2829
"publishConfig": {
2930
"access": "public"

packages/cache/types/tsconfig.json

-4
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,7 @@
66
"lib": ["es6", "dom"],
77
"module": "commonjs",
88
"noEmit": true,
9-
"noImplicitAny": true,
10-
"noImplicitThis": true,
119
"strict": true,
12-
"strictNullChecks": true,
13-
"strictFunctionTypes": true,
1410
"target": "es5",
1511
"typeRoots": ["../"],
1612
"types": []

packages/css/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@
3434
},
3535
"devDependencies": {
3636
"@babel/core": "^7.13.10",
37-
"dtslint": "^0.3.0"
37+
"dtslint": "^4.2.1",
38+
"typescript": "^4.5.5"
3839
},
3940
"author": "Kye Hohenberger",
4041
"homepage": "https://emotion.sh",

packages/css/types/tsconfig.json

-4
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,7 @@
66
"lib": ["es6", "dom"],
77
"module": "commonjs",
88
"noEmit": true,
9-
"noImplicitAny": true,
10-
"noImplicitThis": true,
119
"strict": true,
12-
"strictNullChecks": true,
13-
"strictFunctionTypes": true,
1410
"target": "es5",
1511
"typeRoots": ["../"],
1612
"types": []

packages/hash/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919
"test:typescript": "dtslint types"
2020
},
2121
"devDependencies": {
22-
"dtslint": "^0.3.0"
22+
"dtslint": "^4.2.1",
23+
"typescript": "^4.5.5"
2324
},
2425
"browser": {
2526
"./dist/emotion-hash.cjs.js": "./dist/emotion-hash.browser.cjs.js",

packages/hash/types/tsconfig.json

-4
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,7 @@
55
"lib": ["es6", "dom"],
66
"module": "commonjs",
77
"noEmit": true,
8-
"noImplicitAny": true,
9-
"noImplicitThis": true,
108
"strict": true,
11-
"strictNullChecks": true,
12-
"strictFunctionTypes": true,
139
"target": "es5",
1410
"typeRoots": ["../"],
1511
"types": []

packages/is-prop-valid/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@
1717
"@emotion/memoize": "^0.7.4"
1818
},
1919
"devDependencies": {
20-
"dtslint": "^0.3.0"
20+
"dtslint": "^4.2.1",
21+
"typescript": "^4.5.5"
2122
},
2223
"files": [
2324
"src",

packages/is-prop-valid/types/tsconfig.json

-4
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,7 @@
55
"lib": ["es6", "dom"],
66
"module": "commonjs",
77
"noEmit": true,
8-
"noImplicitAny": true,
9-
"noImplicitThis": true,
108
"strict": true,
11-
"strictNullChecks": true,
12-
"strictFunctionTypes": true,
139
"target": "es5",
1410
"typeRoots": ["../"],
1511
"types": []

packages/jest/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,14 @@
3939
"@emotion/css": "11.7.1",
4040
"@emotion/react": "11.8.1",
4141
"@types/jest": "^27.0.3",
42-
"dtslint": "^0.3.0",
42+
"dtslint": "^4.2.1",
4343
"enzyme-to-json": "^3.6.1",
4444
"preact": "^8.2.9",
4545
"preact-render-to-json": "^3.6.6",
4646
"pretty-format": "^22.4.3",
4747
"react": "16.14.0",
48-
"react-dom": "16.14.0"
48+
"react-dom": "16.14.0",
49+
"typescript": "^4.5.5"
4950
},
5051
"author": "Kye Hohenberger",
5152
"homepage": "https://emotion.sh",

packages/jest/types/tsconfig.json

-4
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,7 @@
66
"lib": ["es6", "dom"],
77
"module": "commonjs",
88
"noEmit": true,
9-
"noImplicitAny": true,
10-
"noImplicitThis": true,
119
"strict": true,
12-
"strictNullChecks": true,
13-
"strictFunctionTypes": true,
1410
"target": "es5",
1511
"types": []
1612
},

packages/memoize/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414
"access": "public"
1515
},
1616
"devDependencies": {
17-
"dtslint": "^0.3.0"
17+
"dtslint": "^4.2.1",
18+
"typescript": "^4.5.5"
1819
},
1920
"files": [
2021
"src",

packages/memoize/types/tsconfig.json

-4
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,7 @@
55
"lib": ["es6", "dom"],
66
"module": "commonjs",
77
"noEmit": true,
8-
"noImplicitAny": true,
9-
"noImplicitThis": true,
108
"strict": true,
11-
"strictNullChecks": true,
12-
"strictFunctionTypes": true,
139
"target": "es5",
1410
"typeRoots": ["../"],
1511
"types": []

packages/native/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@
1717
"devDependencies": {
1818
"@babel/core": "^7.13.10",
1919
"@types/react-native": "^0.63.2",
20-
"dtslint": "^0.3.0",
20+
"dtslint": "^4.2.1",
2121
"react": "16.14.0",
22-
"react-native": "^0.63.2"
22+
"react-native": "^0.63.2",
23+
"typescript": "^4.5.5"
2324
},
2425
"dependencies": {
2526
"@emotion/primitives-core": "^11.0.0"

packages/native/types/tests.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ declare module '@emotion/react' {
2323
const cssObject = {
2424
height: 100,
2525
width: '100%',
26-
display: 'flex',
26+
display: 'flex' as const,
2727
position: undefined
28-
} as const
28+
}
2929

3030
const className = css`
3131
${(true as boolean) && ''}

packages/native/types/tsconfig.json

+2-5
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,11 @@
66
"lib": ["es6", "dom"],
77
"module": "commonjs",
88
"noEmit": true,
9-
"noImplicitAny": true,
10-
"noImplicitThis": true,
119
"strict": true,
12-
"strictNullChecks": true,
13-
"strictFunctionTypes": true,
1410
"target": "es5",
1511
"typeRoots": ["../"],
16-
"types": []
12+
"types": [],
13+
"skipLibCheck": true
1714
},
1815
"include": ["./*.ts", "./*.tsx"]
1916
}

packages/react/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,11 @@
5454
"@emotion/server": "11.4.0",
5555
"@emotion/styled": "11.8.1",
5656
"@types/react": "^16.9.11",
57-
"dtslint": "^0.3.0",
57+
"dtslint": "^4.2.1",
5858
"html-tag-names": "^1.1.2",
5959
"react": "16.14.0",
60-
"svg-tag-names": "^1.1.1"
60+
"svg-tag-names": "^1.1.1",
61+
"typescript": "^4.5.5"
6162
},
6263
"repository": "https://github.com/emotion-js/emotion/tree/main/packages/react",
6364
"publishConfig": {

packages/react/types/tsconfig.json

-4
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,7 @@
66
"lib": ["es6", "dom"],
77
"module": "commonjs",
88
"noEmit": true,
9-
"noImplicitAny": true,
10-
"noImplicitThis": true,
119
"strict": true,
12-
"strictNullChecks": true,
13-
"strictFunctionTypes": true,
1410
"target": "es5",
1511
"typeRoots": ["../"],
1612
"types": []

packages/serialize/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
"csstype": "^3.0.2"
2222
},
2323
"devDependencies": {
24-
"dtslint": "^0.3.0"
24+
"dtslint": "^4.2.1",
25+
"typescript": "^4.5.5"
2526
},
2627
"files": [
2728
"src",

packages/serialize/types/tsconfig.json

-4
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,7 @@
66
"lib": ["es6", "dom"],
77
"module": "commonjs",
88
"noEmit": true,
9-
"noImplicitAny": true,
10-
"noImplicitThis": true,
119
"strict": true,
12-
"strictNullChecks": true,
13-
"strictFunctionTypes": true,
1410
"target": "es5",
1511
"typeRoots": ["../"],
1612
"types": []

packages/server/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@
3232
"@emotion/css": "11.7.1",
3333
"@emotion/css-prettifier": "1.0.1",
3434
"@types/node": "^10.11.4",
35-
"dtslint": "^0.3.0"
35+
"dtslint": "^4.2.1",
36+
"typescript": "^4.5.5"
3637
},
3738
"author": "Kye Hohenberger",
3839
"homepage": "https://emotion.sh",

packages/server/types/tsconfig.json

+2-5
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,11 @@
66
"lib": ["es6"],
77
"module": "commonjs",
88
"noEmit": true,
9-
"noImplicitAny": true,
10-
"noImplicitThis": true,
119
"strict": true,
12-
"strictNullChecks": true,
13-
"strictFunctionTypes": true,
1410
"target": "es5",
1511
"typeRoots": ["../"],
16-
"types": []
12+
"types": [],
13+
"skipLibCheck": true
1714
},
1815
"include": ["./*.ts", "./*.tsx"]
1916
}

packages/sheet/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
"types/*.d.ts"
2424
],
2525
"devDependencies": {
26-
"dtslint": "^0.3.0"
26+
"dtslint": "^4.2.1",
27+
"typescript": "^4.5.5"
2728
}
2829
}

packages/sheet/types/tsconfig.json

-4
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,7 @@
66
"lib": ["es6", "dom"],
77
"module": "commonjs",
88
"noEmit": true,
9-
"noImplicitAny": true,
10-
"noImplicitThis": true,
119
"strict": true,
12-
"strictNullChecks": true,
13-
"strictFunctionTypes": true,
1410
"target": "es5",
1511
"typeRoots": ["../"],
1612
"types": []

packages/styled/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,9 @@
3333
"devDependencies": {
3434
"@babel/core": "^7.13.10",
3535
"@emotion/react": "11.8.1",
36-
"dtslint": "^0.3.0",
37-
"react": "16.14.0"
36+
"dtslint": "^4.2.1",
37+
"react": "16.14.0",
38+
"typescript": "^4.5.5"
3839
},
3940
"publishConfig": {
4041
"access": "public"

packages/styled/types/tsconfig.json

-4
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,7 @@
77
"lib": ["es6", "dom"],
88
"module": "commonjs",
99
"noEmit": true,
10-
"noImplicitAny": true,
11-
"noImplicitThis": true,
1210
"strict": true,
13-
"strictNullChecks": true,
14-
"strictFunctionTypes": true,
1511
"target": "es5",
1612
"typeRoots": ["../"],
1713
"types": []

packages/utils/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
"types/*.d.ts"
2424
],
2525
"devDependencies": {
26-
"dtslint": "^0.3.0"
26+
"dtslint": "^4.2.1",
27+
"typescript": "^4.5.5"
2728
}
2829
}

packages/utils/types/tsconfig.json

-4
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,7 @@
66
"lib": ["es6", "dom"],
77
"module": "commonjs",
88
"noEmit": true,
9-
"noImplicitAny": true,
10-
"noImplicitThis": true,
119
"strict": true,
12-
"strictNullChecks": true,
13-
"strictFunctionTypes": true,
1410
"target": "es5",
1511
"typeRoots": ["../"],
1612
"types": []

packages/weak-memoize/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414
"access": "public"
1515
},
1616
"devDependencies": {
17-
"dtslint": "^0.3.0"
17+
"dtslint": "^4.2.1",
18+
"typescript": "^4.5.5"
1819
},
1920
"files": [
2021
"src",

packages/weak-memoize/types/tsconfig.json

-4
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,7 @@
55
"lib": ["es6", "dom"],
66
"module": "commonjs",
77
"noEmit": true,
8-
"noImplicitAny": true,
9-
"noImplicitThis": true,
108
"strict": true,
11-
"strictNullChecks": true,
12-
"strictFunctionTypes": true,
139
"target": "es5",
1410
"typeRoots": ["../"],
1511
"types": []

playgrounds/cra/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"start": "react-scripts start",
1313
"build": "react-scripts build",
1414
"test": "react-scripts test",
15+
"test:typescript": "exit 0",
1516
"eject": "react-scripts eject"
1617
},
1718
"browserslist": {

playgrounds/nextjs/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"scripts": {
66
"dev": "next dev -p 4000",
77
"build": "next build",
8+
"test:typescript": "exit 0",
89
"start": "next start"
910
},
1011
"dependencies": {

0 commit comments

Comments
 (0)