Skip to content

Commit cabfac7

Browse files
author
bors-servo
authored
Auto merge of rust-lang#704 - fitzgen:bitfields-into-ir, r=emilio
Move bitfields into the IR This PR moves bitfields and the computation of their allocation units into the IR. They were previously computed on-the-fly during code generation. In addition to breaking up and compartmentalizing a portion of the gargantuan `CodeGeneration` implementation for `CompInfo`, this paves the way for adding const-fn bitfield unit constructors. Also some improvements to `tests/test-one.sh`. Also some graphviz output improvements that got tangled up in the last commit without a good way to pull them out into their own commit (sorry). r? @emilio
2 parents e87699c + d769f0e commit cabfac7

23 files changed

+1591
-953
lines changed

Cargo.lock

+7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

+1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ cexpr = "0.2"
4646
cfg-if = "0.1.0"
4747
clang-sys = { version = "0.18.0", features = ["runtime", "clang_3_9"] }
4848
lazy_static = "0.2.1"
49+
peeking_take_while = "0.1.2"
4950
syntex_syntax = "0.58"
5051
regex = "0.2"
5152
# This kinda sucks: https://github.com/rust-lang/cargo/issues/1982

ci/test.sh

+2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
set -xeu
44
cd "$(dirname "$0")/.."
55

6+
export RUST_BACKTRACE=1
7+
68
# Regenerate the test headers' bindings in debug and release modes, and assert
79
# that we always get the expected generated bindings.
810

0 commit comments

Comments
 (0)