Skip to content

Commit 5229dc2

Browse files
committed
Document why we shouldn't be tracing module -> child edges
1 parent eba4f31 commit 5229dc2

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/ir/item.rs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,12 @@ impl TypeCollector for Item {
205205
ItemKind::Var(ref var) => {
206206
types.insert(var.ty());
207207
}
208-
_ => {} // FIXME.
208+
ItemKind::Module(_) => {
209+
// Module -> children edges are "weak", and we do not want to
210+
// trace them. If we did, then whitelisting wouldn't work as
211+
// expected: everything in every module would end up
212+
// whitelisted.
213+
}
209214
}
210215
}
211216
}

0 commit comments

Comments
 (0)