Skip to content

Commit 1926536

Browse files
committed
Rename the TemplateDeclaration trait to TemplateParameters
The trait is all about accessing template parameters, and is also implemented for things that are not template declarations or definitions, but do end up using template parameters one way or another. The new name makes more sense.
1 parent 72bbb90 commit 1926536

File tree

7 files changed

+15
-14
lines changed

7 files changed

+15
-14
lines changed

src/codegen/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ use ir::layout::Layout;
2222
use ir::module::Module;
2323
use ir::objc::{ObjCInterface, ObjCMethod};
2424
use ir::template::{AsNamed, TemplateInstantiation};
25-
use ir::ty::{TemplateDeclaration, Type, TypeKind};
25+
use ir::ty::{TemplateParameters, Type, TypeKind};
2626
use ir::var::Var;
2727

2828
use std::borrow::Cow;

src/ir/comp.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ use super::derive::{CanDeriveCopy, CanDeriveDebug, CanDeriveDefault};
66
use super::item::Item;
77
use super::layout::Layout;
88
use super::traversal::{EdgeKind, Trace, Tracer};
9-
use super::ty::TemplateDeclaration;
9+
use super::ty::TemplateParameters;
1010
use clang;
1111
use parse::{ClangItemParser, ParseError};
1212
use std::cell::Cell;
@@ -812,7 +812,7 @@ impl CompInfo {
812812
}
813813
}
814814

815-
impl TemplateDeclaration for CompInfo {
815+
impl TemplateParameters for CompInfo {
816816
fn self_template_params(&self,
817817
_ctx: &BindgenContext)
818818
-> Option<Vec<ItemId>> {

src/ir/context.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ use super::module::{Module, ModuleKind};
88
use super::named::{UsedTemplateParameters, analyze};
99
use super::template::TemplateInstantiation;
1010
use super::traversal::{self, Edge, ItemTraversal};
11-
use super::ty::{FloatKind, TemplateDeclaration, Type, TypeKind};
11+
use super::ty::{FloatKind, TemplateParameters, Type, TypeKind};
1212
use BindgenOptions;
1313
use cexpr;
1414
use callbacks::ParseCallbacks;
@@ -1501,7 +1501,7 @@ impl PartialType {
15011501
}
15021502
}
15031503

1504-
impl TemplateDeclaration for PartialType {
1504+
impl TemplateParameters for PartialType {
15051505
fn self_template_params(&self,
15061506
_ctx: &BindgenContext)
15071507
-> Option<Vec<ItemId>> {

src/ir/item.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ use super::layout::Opaque;
1010
use super::module::Module;
1111
use super::template::AsNamed;
1212
use super::traversal::{EdgeKind, Trace, Tracer};
13-
use super::ty::{TemplateDeclaration, Type, TypeKind};
13+
use super::ty::{TemplateParameters, Type, TypeKind};
1414
use clang;
1515
use clang_sys;
1616
use parse::{ClangItemParser, ClangSubItemParser, ParseError, ParseResult};
@@ -830,7 +830,7 @@ impl DotAttributes for Item {
830830
}
831831
}
832832

833-
impl TemplateDeclaration for ItemId {
833+
impl TemplateParameters for ItemId {
834834
fn self_template_params(&self,
835835
ctx: &BindgenContext)
836836
-> Option<Vec<ItemId>> {
@@ -839,15 +839,15 @@ impl TemplateDeclaration for ItemId {
839839
}
840840
}
841841

842-
impl TemplateDeclaration for Item {
842+
impl TemplateParameters for Item {
843843
fn self_template_params(&self,
844844
ctx: &BindgenContext)
845845
-> Option<Vec<ItemId>> {
846846
self.kind.self_template_params(ctx)
847847
}
848848
}
849849

850-
impl TemplateDeclaration for ItemKind {
850+
impl TemplateParameters for ItemKind {
851851
fn self_template_params(&self,
852852
ctx: &BindgenContext)
853853
-> Option<Vec<ItemId>> {

src/ir/named.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ use super::context::{BindgenContext, ItemId};
130130
use super::item::{Item, ItemSet};
131131
use super::template::{AsNamed, TemplateInstantiation};
132132
use super::traversal::{EdgeKind, Trace};
133-
use super::ty::{TemplateDeclaration, TypeKind};
133+
use super::ty::{TemplateParameters, TypeKind};
134134
use std::collections::{HashMap, HashSet};
135135
use std::fmt;
136136

src/ir/ty.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,8 @@ use std::mem;
8484
/// ... |Wtf | ... | Some([T]) |
8585
/// ... |Qux | ... | None |
8686
/// ----+------+-----+----------------------+
87-
pub trait TemplateDeclaration {
87+
88+
pub trait TemplateParameters {
8889
/// Get the set of `ItemId`s that make up this template declaration's free
8990
/// template parameters.
9091
///
@@ -623,15 +624,15 @@ fn is_invalid_named_type_empty_name() {
623624
}
624625

625626

626-
impl TemplateDeclaration for Type {
627+
impl TemplateParameters for Type {
627628
fn self_template_params(&self,
628629
ctx: &BindgenContext)
629630
-> Option<Vec<ItemId>> {
630631
self.kind.self_template_params(ctx)
631632
}
632633
}
633634

634-
impl TemplateDeclaration for TypeKind {
635+
impl TemplateParameters for TypeKind {
635636
fn self_template_params(&self,
636637
ctx: &BindgenContext)
637638
-> Option<Vec<ItemId>> {

src/uses.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
3838
use ir::context::BindgenContext;
3939
use ir::item::{Item, ItemAncestors, ItemCanonicalName};
40-
use ir::ty::TemplateDeclaration;
40+
use ir::ty::TemplateParameters;
4141
use std::io;
4242

4343
// Like `canonical_path`, except we always take namespaces into account, ignore

0 commit comments

Comments
 (0)