Merge pull request #882 from bmish/no-pause-test-check-imports

Check imports in `no-pause-test` rule

Author: bmish

lib/rules/no-pause-test.js

@@ -2,6 +2,7 @@
 
 const emberUtils = require('../utils/ember');
 const types = require('../utils/types');
+const { getImportIdentifier } = require('../utils/import');
 
 const ERROR_MESSAGE = 'Do not use `pauseTest()`';
 
@@ -30,12 +31,21 @@ module.exports = {
       return {};
     }
 
+    let importedPauseTestName;
+
     return {
+      ImportDeclaration(node) {
+        if (node.source.value === '@ember/test-helpers') {
+          importedPauseTestName =
+            importedPauseTestName || getImportIdentifier(node, '@ember/test-helpers', 'pauseTest');
+        }
+      },
+
       CallExpression(node) {
         const { callee } = node;
 
         if (
-          (types.isIdentifier(callee) && callee.name === 'pauseTest') ||
+          (types.isIdentifier(callee) && callee.name === importedPauseTestName) ||
           (types.isThisExpression(callee.object) &&
             types.isIdentifier(callee.property) &&
             callee.property.name === 'pauseTest')

tests/lib/rules/no-pause-test.js

@@ -34,7 +34,12 @@ ruleTester.run('no-pause-test', rule, {
     },
     {
       filename: TEST_FILE_NAME,
-      code: 'pauseTest.otherFunction(myFunction);',
+      code: "import { pauseTest } from '@ember/test-helpers'; pauseTest.otherFunction(myFunction);",
+    },
+    {
+      // Missing import:
+      filename: TEST_FILE_NAME,
+      code: 'pauseTest();',
     },
     {
       filename: 'not-a-test-file.js',
@@ -50,7 +55,14 @@ ruleTester.run('no-pause-test', rule, {
     },
     {
       filename: TEST_FILE_NAME,
-      code: 'async () => { await pauseTest(); }',
+      code: "import { pauseTest } from '@ember/test-helpers'; pauseTest();",
+      output: null,
+      errors: [{ message: ERROR_MESSAGE, type: 'CallExpression' }],
+    },
+    {
+      // Renamed import:
+      filename: TEST_FILE_NAME,
+      code: "import { pauseTest as pt } from '@ember/test-helpers'; pt();",
       output: null,
       errors: [{ message: ERROR_MESSAGE, type: 'CallExpression' }],
     },
@@ -67,6 +79,7 @@ ruleTester.run('no-pause-test', rule, {
     {
       filename: TEST_FILE_NAME,
       code: `
+        import { pauseTest } from '@ember/test-helpers';
         test('bar', async function(assert) {
           await pauseTest();
         });