Skip to content

Commit 7712bd7

Browse files
committed
no-ember-super-in-es-classes lint rule's message should include the correct syntax
1 parent 7ffc8b9 commit 7712bd7

File tree

2 files changed

+21
-9
lines changed

2 files changed

+21
-9
lines changed

lib/rules/no-ember-super-in-es-classes.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ module.exports = {
2121
) {
2222
context.report({
2323
node,
24-
message: "Don't use `this._super` in ES classes",
24+
message: "Don't use `this._super` in ES classes; instead, you should use super()",
2525
fix(fixer) {
2626
let method = node;
2727
while (method.type !== 'MethodDefinition') {

tests/lib/rules/no-ember-super-in-es-classes.js

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,40 +23,52 @@ eslintTester.run('no-ember-super-in-es-classes', rule, {
2323
{
2424
code: 'class Foo { init() { this._super(); } }',
2525
output: 'class Foo { init() { super.init(); } }',
26-
errors: [{ message: "Don't use `this._super` in ES classes" }],
26+
errors: [
27+
{ message: "Don't use `this._super` in ES classes; instead, you should use super()" },
28+
],
2729
},
2830
{
2931
code: 'class Foo { init(a, b) { this._super(a); } }',
3032
output: 'class Foo { init(a, b) { super.init(a); } }',
31-
errors: [{ message: "Don't use `this._super` in ES classes" }],
33+
errors: [
34+
{ message: "Don't use `this._super` in ES classes; instead, you should use super()" },
35+
],
3236
},
3337
{
3438
code: 'class Foo { init() { this._super(...arguments); } }',
3539
output: 'class Foo { init() { super.init(...arguments); } }',
36-
errors: [{ message: "Don't use `this._super` in ES classes" }],
40+
errors: [
41+
{ message: "Don't use `this._super` in ES classes; instead, you should use super()" },
42+
],
3743
},
3844
{
3945
code: 'class Foo { init() { this._super.apply(this, arguments); } }',
4046
output: 'class Foo { init() { super.init.apply(this, arguments); } }',
41-
errors: [{ message: "Don't use `this._super` in ES classes" }],
47+
errors: [
48+
{ message: "Don't use `this._super` in ES classes; instead, you should use super()" },
49+
],
4250
},
4351
{
4452
code: 'class Foo { init() { if (x) { this._super(1); } else { this._super(2); } } }',
4553
output: 'class Foo { init() { if (x) { super.init(1); } else { super.init(2); } } }',
4654
errors: [
47-
{ message: "Don't use `this._super` in ES classes" },
48-
{ message: "Don't use `this._super` in ES classes" },
55+
{ message: "Don't use `this._super` in ES classes; instead, you should use super()" },
56+
{ message: "Don't use `this._super` in ES classes; instead, you should use super()" },
4957
],
5058
},
5159
{
5260
code: 'class Foo { "a b"() { this._super(); } }',
5361
output: 'class Foo { "a b"() { super["a b"](); } }',
54-
errors: [{ message: "Don't use `this._super` in ES classes" }],
62+
errors: [
63+
{ message: "Don't use `this._super` in ES classes; instead, you should use super()" },
64+
],
5565
},
5666
{
5767
code: 'class Foo { [Symbol.iterator]() { this._super(); } }',
5868
output: 'class Foo { [Symbol.iterator]() { super[Symbol.iterator](); } }',
59-
errors: [{ message: "Don't use `this._super` in ES classes" }],
69+
errors: [
70+
{ message: "Don't use `this._super` in ES classes; instead, you should use super()" },
71+
],
6072
},
6173
],
6274
});

0 commit comments

Comments
 (0)